Support docker-in-docker on Ubuntu Noble (24.04) #969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company=Elefant-Ai |
6 tasks
samruddhikhandale
requested changes
May 13, 2024
| DOCKER_MOBY_ARCHIVE_VERSION_CODENAMES="bookworm buster bullseye bionic focal jammy" | ||
| DOCKER_LICENSED_ARCHIVE_VERSION_CODENAMES="bookworm buster bullseye bionic focal hirsute impish jammy" | ||
| DOCKER_MOBY_ARCHIVE_VERSION_CODENAMES="bookworm buster bullseye bionic focal jammy noble" | ||
| DOCKER_LICENSED_ARCHIVE_VERSION_CODENAMES="bookworm buster bullseye bionic focal hirsute impish jammy noble" |
There was a problem hiding this comment.
Can you help add a similar test 👇 for the noble image? Thanks!
features/test/docker-in-docker/scenarios.json
Lines 2 to 10 in 18c1823
There was a problem hiding this comment.
Better idea, I think we should update these 👇 workflows and add the mcr.microsoft.com/devcontainers/base:noble image to the baseImage
features/.github/workflows/test-all.yaml
Lines 43 to 51 in 18c1823
features/.github/workflows/test-pr.yaml
Lines 50 to 58 in 18c1823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny changed seem to work for me.
https://github.com/jjh42/docker-in-docker-noble
as a temporary workaround you can use
"ghcr.io/jjh42/docker-in-docker-noble/docker-in-docker:latest": {},
instead of the official docker-in-docker feature.