-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Terraform] feature fallback fix #912
Merged
samruddhikhandale
merged 26 commits into
devcontainers:main
from
gauravsaini04:terraform_feature_fallback_fix
Mar 28, 2024
Merged
[Terraform] feature fallback fix #912
samruddhikhandale
merged 26 commits into
devcontainers:main
from
gauravsaini04:terraform_feature_fallback_fix
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samruddhikhandale
requested changes
Mar 15, 2024
samruddhikhandale
requested changes
Mar 18, 2024
samruddhikhandale
requested changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks great, left some comments
samruddhikhandale
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature name:
Description:
This PR introduces the following functionality:
terraform
feature does not have a source binary released yet, then it will continue installing the previous working version for which a source binary will be availableterraform
feature -cosign, terraform, tflint, terragrunt, tfsec, terraform_docs
Changelog:
install.sh
such that the fallback mechanism is properly configured for all these above listed tools/ packagescurl
command thus representing a scenario when trying to access a source binary which is not deployed yet, then it will pick up the binary for the latest released tag which will eventually work successfully, and ifgithub api
limits are reached then will try to find a prev. version fromfind_prev_version_from_git_tags()
function and get the binary for that instead.Checklist: