Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile not downloading #876

Merged
merged 9 commits into from
Mar 1, 2024
Merged

Conversation

nebula-it
Copy link
Contributor

Since the powershell folder is owned by root, the profile download fails without becoming sudo first.

ls -l /opt/microsoft/powershell/
total 0
drwxr-xr-x. 1 root root 22 Feb 23 08:37 7

Since the powershell folder is owned by root, the profile download fails without becoming sudo first.
```
ls -l /opt/microsoft/powershell/
total 0
drwxr-xr-x. 1 root root 22 Feb 23 08:37 7
```
@nebula-it nebula-it requested a review from a team as a code owner February 23, 2024 08:42
@nebula-it
Copy link
Contributor Author

@samruddhikhandale Quick fix here

src/powershell/install.sh Outdated Show resolved Hide resolved
@nebula-it nebula-it requested a review from eitsupi February 29, 2024 00:01
@nebula-it
Copy link
Contributor Author

@samruddhikhandale tests are good, mind approving this please

src/powershell/install.sh Show resolved Hide resolved
src/powershell/install.sh Show resolved Hide resolved
src/powershell/install.sh Outdated Show resolved Hide resolved
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!
Let's merge in when the tests are 🟢

@nebula-it
Copy link
Contributor Author

Yayy, everything looks 🟢

@samruddhikhandale samruddhikhandale merged commit 025cae1 into devcontainers:main Mar 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants