Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for including PowerShell profile #804

Merged
merged 14 commits into from
Feb 23, 2024
Merged

Add support for including PowerShell profile #804

merged 14 commits into from
Feb 23, 2024
+17 −3

Conversation

nebula-it
Copy link
Contributor

No description provided.

@nebula-it nebula-it requested a review from a team as a code owner January 24, 2024 17:02
samruddhikhandale
samruddhikhandale requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time in contributing the changes.

I have left some comments and clarifying questions, thanks!

src/powershell/install.sh Show resolved Hide resolved
src/powershell/install.sh Show resolved Hide resolved
src/powershell/install.sh Show resolved Hide resolved
src/powershell/install.sh Show resolved Hide resolved
samruddhikhandale
samruddhikhandale requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for answering my questions, appreciate it. Left few more comments!

src/powershell/devcontainer-feature.json Outdated Show resolved Hide resolved
src/powershell/install.sh Show resolved Hide resolved
@nebula-it @samruddhikhandale
Update src/powershell/devcontainer-feature.json
280beb1 
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
samruddhikhandale
samruddhikhandale requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for some test coverage, then we are all set.

src/powershell/install.sh Show resolved Hide resolved
samruddhikhandale
samruddhikhandale requested changes Feb 22, 2024
View reviewed changes
src/powershell/README.md Outdated Show resolved Hide resolved
test/powershell/scenarios.json Outdated Show resolved Hide resolved
test/powershell/testProfile.ps1 Outdated Show resolved Hide resolved
samruddhikhandale
samruddhikhandale approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ⚡

Let's wait for test runs to turn 🟢 before we merge it!

@samruddhikhandale samruddhikhandale merged commit c04ead0 into devcontainers:main Feb 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nebula-it @samruddhikhandale