-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect to Ubuntu keyserver via port 80 #719
Conversation
This helps work around corporate firewalls blocking the default HKP port 11371. Closes devcontainers#717
@microsoft-github-policy-service agree company="DSM-Firmenich" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋
Thanks for contributing this change and providing a detailed explanation on #717
Have you looked at #323? We intentionally updated the keyserver in #323 to address "gpg key" issues with several different users. Hence, as this could be a breaking change for users, I don't think we should submit this PR as is.
Instead, I wonder if a similar change to #451 would work in your case? This would be helpful if you have a proxy setup on your machine.
Hello @samruddhikhandale and thank you for the friendly and detailed message! While I am behind a corporate firewall, we do not use a proxy server (none that is explicitly specified by the user anyway). Hence, specifying a proxy setting is unfortunately not an option for me. Since you mentioned that apparently for some users the Ubuntu key server can only be accessed via port 80 (that would include me), while for others it can only be accessed via the default port (which is blocked in my network and in many others -- which is the reason why Ubuntu chose to support port 80 in addition in the first place!), I would like to revive your proposal of simply adding both options to all features? If the connection to one fails, the next one will be tried. What do you think? |
Yes, that makes complete sense to me and thanks for being willing to contribute the change. Let me know if you need any help with the changes. |
This helps work around corporate firewalls blocking the default HKP port 11371.
Closes #717