Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[terraform] Update retry logic to handle DNS-related errors more gracefully #713

Conversation

alexander-smolyakov
Copy link
Contributor

Feature name:

  • ghcr.io/devcontainers/features/terraform

Description:

This PR aims to update the retry logic to handle the gpg: keyserver receive failed: Server indicated a failure error more gracefully.

The gpg returns the keyserver receive failed: Server indicated a failure error if something goes wrong with DNS-related stuff. It looks like gpg could use several libraries for working with DNS servers based on macros values. Related code:

This means that gpg could work with DNS servers differently than other tools.

The fix is to try to get the IP address of the GPG keyserver and explicitly pass it to the gpg tool to avoid DNS-related issues.

Changelog:

  • Retry logic updated: Additional tries with explicitly passing the keyserver IP address were added;
  • Thednsutils package added to dependencies;

Attached related issue:

Checklist:

  • Checked that applied changes work as expected

- Add `dnsutils` package to dependencies
- Update retry logic to handle DNS-related errors more gracefully
@alexander-smolyakov alexander-smolyakov requested a review from a team as a code owner October 4, 2023 11:09
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 🎉

@samruddhikhandale samruddhikhandale merged commit 90a9b1d into devcontainers:main Oct 4, 2023
11 checks passed
@alexander-smolyakov alexander-smolyakov deleted the terraform-update_retry_logic branch October 5, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants