Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[desktop-lite] - vnc_resolution - set thru env var #1112

Merged
merged 7 commits into from
Sep 9, 2024
Merged

[desktop-lite] - vnc_resolution - set thru env var #1112

merged 7 commits into from
Sep 9, 2024

Conversation

gauravsaini04
Copy link
Contributor

@gauravsaini04 gauravsaini04 commented Sep 2, 2024 •
edited
Loading

Feature Name

  • Desktop-lite

Description

  • Escaped the variables in desktop-init.sh file at the init of the file as a solution to feature's issue #945

changelog

  • VNC_RESOLUTION as an env. var. should get picked up by the desktop-init.sh file due to the above mentioned changes

@gauravsaini04 gauravsaini04 mentioned this pull request Sep 2, 2024
Closed
@gauravsaini04 gauravsaini04 marked this pull request as ready for review September 4, 2024 05:52
@gauravsaini04 gauravsaini04 requested a review from a team as a code owner September 4, 2024 05:52
samruddhikhandale
samruddhikhandale requested changes Sep 5, 2024
View reviewed changes
src/desktop-lite/install.sh Show resolved Hide resolved
src/desktop-lite/install.sh Outdated Show resolved Hide resolved
src/desktop-lite/install.sh Outdated Show resolved Hide resolved
test/desktop-lite/scenarios.json Show resolved Hide resolved
samruddhikhandale
samruddhikhandale approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samruddhikhandale samruddhikhandale linked an issue Sep 9, 2024 that may be closed by this pull request
[desktop-lite] Entrypoint script does not use VNC_RESOLUTION defined by containerEnv #945
Closed
@samruddhikhandale samruddhikhandale merged commit b0667c5 into devcontainers:main Sep 9, 2024
12 checks passed
@gauravsaini04 gauravsaini04 deleted the desktop-lite_vnc-resolution_test_env_var branch September 10, 2024 01:49
@gauravsaini04 gauravsaini04 mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[desktop-lite] Entrypoint script does not use VNC_RESOLUTION defined by containerEnv
2 participants
@gauravsaini04 @samruddhikhandale