-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installing latest git from PPA in bionic #1056
Merged
samruddhikhandale
merged 6 commits into
devcontainers:main
from
trxcllnt:fix/git-feature-on-bionic
Jul 26, 2024
Merged
Fix installing latest git from PPA in bionic #1056
samruddhikhandale
merged 6 commits into
devcontainers:main
from
trxcllnt:fix/git-feature-on-bionic
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
changed the title
Add latest git from PPA in bionic scenario test
Fix installing latest git from PPA in bionic
Jul 23, 2024
It appears |
samruddhikhandale
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix, appreciate it.
Let's merge once the tests are green!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keys.openpgp.org
strips user IDs from keys unless the key owner grants permission to share them. This leads to gpg rejecting the keys instead of importing them, and failing to install thegit
feature.This PR enforces an explicit order when testing and importing keys from the keyservers list, ensuring
keys.openpgp.org
is the last keyserver to be tried. Previously, keyservers were selected based on bash's associative array key enumeration order, but this order is different between Bash v4 (in Ubuntu Bionic) and v5 (Ubuntu Focal+).I believe the issue isn't seen in Bash v5 because the ubuntu keyservers are enumerated first, not because the gpg version in Focal accepts keys without user IDs.
If this is the case, we should either stop attempting to import keys from
keys.openpgp.org
, or encourage the owner ofE1DD270288B4E6030699E45FA1715D88E1DF1F24
to grantopenpgp.org
permission to share their user ID.Fixes #1055 and adds a new scenario test.
Note: I believe this fix may need to be applied to all features modified in #1016.