[powershell]: Fix manual PowerShell installation binary execution permissions
#1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure execution permissions for pwsh - correct path from /usr/local/bin/pwsh to /usr/bin/pwsh - register as shell in /etc/shells
This will avoid build failures when multiple features depend on this PowerShell package
samruddhikhandale
requested changes
Jul 26, 2024
|
Is there something blocking completion of this pull request? |
|
@DonPwrShellHunt Thanks for the nudge! We are waiting for the author to add test coverage validating his change as well as fix the broken test. |
jpawlowski
changed the title
[powershell]: Fix manual PowerShell installation binary execution permissions
|
@samruddhikhandale would you be kind enough to review this PR and, if all is well, merge it into the |
samruddhikhandale
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aligns the manual setup of
pwshwith the settings the official Debian module uses:/usr/bin/pwshinstead of/usr/bin/local/pwsh/etc/shells(usingadd-shell)Also, because of #1041, this will also enforce execution permissions of the
/opt/microsoft/powershell/7/pwshbinary.The package version minor version number is increased to
1.5.0. Also, version suggestions for PowerShell installation were updated to remove deprecated version7.1and add version7.2,7.3and7.4to the selection (they can still be installed as this is only the suggestions presented to the user).Some other maintenance work:
validate_powershell_installationtest to validate generalpwshbinary installation