changes acc. to comments and added tests

src/kubectl-helm-minikube/install.sh

@@ -125,7 +125,8 @@ esac
 # Function to fetch the version released prior to the latest version
 get_previous_version() {
     repo_url=$1
-    curl -s "$repo_url" | jq -r 'del(.[].assets) | .[1].tag_name' # this would del the assets key and then get the second encountered tag_name's value from the filtered array of objects
+    # this would del the assets key and then get the second encountered tag_name's value from the filtered array of objects
+    curl -s "$repo_url" | jq -r 'del(.[].assets) | .[1].tag_name' 
 }
 
 if [ ${KUBECTL_VERSION} != "none" ]; then
@@ -140,17 +141,16 @@ if [ ${KUBECTL_VERSION} != "none" ]; then
         KUBECTL_VERSION="v${KUBECTL_VERSION}"
     fi
     curl -sSL -o /usr/local/bin/kubectl "https://dl.k8s.io/release/${KUBECTL_VERSION}/bin/linux/${architecture}/kubectl"
-    chmod 0755 /usr/local/bin/kubectl
     if [ -e "/usr/local/bin/kubectl" ]; then
         if grep -q "The specified key does not exist." "/usr/local/bin/kubectl"; then 
-            echo -e "\n(!) Failed to fetch the latest artifacts for docker buildx ${KUBECTL_VERSION}..."
             repo_url=https://api.github.com/repos/kubernetes/kubernetes/releases
             requested_version=$(get_previous_version "${repo_url}")
             echo -e "\nAttempting to install ${requested_version}"
             curl -sSL -o /usr/local/bin/kubectl "https://dl.k8s.io/release/${requested_version}/bin/linux/${architecture}/kubectl"
             KUBECTL_VERSION="${requested_version}"
         fi
     fi
+    chmod 0755 /usr/local/bin/kubectl
     if [ "$KUBECTL_SHA256" = "automatic" ]; then
         KUBECTL_SHA256="$(curl -sSL "https://dl.k8s.io/${KUBECTL_VERSION}/bin/linux/${architecture}/kubectl.sha256")"
     fi
@@ -185,7 +185,7 @@ if [ ${HELM_VERSION} != "none" ]; then
     curl -sSL "https://github.com/helm/helm/releases/download/${HELM_VERSION}/${helm_filename}.asc" -o "${tmp_helm_filename}.asc"
     output=$(cat /tmp/helm/"${helm_filename}.asc")
     if [[ "${output}" == *"Not Found"* ]]; then
-        echo -e "\n(!) Failed to fetch the latest artifacts for docker buildx ${HELM_VERSION}..."
+        echo -e "\n(!) Failed to fetch the latest artifacts for helm ${HELM_VERSION}..."
         repo_url=https://api.github.com/repos/helm/helm/releases
         requested_version=$(get_previous_version "${repo_url}")
         echo -e "\nAttempting to install ${requested_version}"
@@ -242,17 +242,17 @@ if [ "${MINIKUBE_VERSION}" != "none" ]; then
     fi
     # latest is also valid in the download URLs 
     curl -sSL -o /usr/local/bin/minikube "https://storage.googleapis.com/minikube/releases/${MINIKUBE_VERSION}/minikube-linux-${architecture}"    
-    chmod 0755 /usr/local/bin/minikube
     if [ -e "/usr/local/bin/minikube" ]; then
         if grep -q "The specified key does not exist." "/usr/local/bin/minikube"; then 
-            echo -e "\n(!) Failed to fetch the latest artifacts for docker buildx ${MINIKUBE_VERSION}..."
+            echo -e "\n(!) Failed to fetch the latest artifacts for minikube ${MINIKUBE_VERSION}..."
             repo_url=https://api.github.com/repos/kubernetes/minikube/releases
             requested_version=$(get_previous_version "${repo_url}")
             echo -e "\nAttempting to install ${requested_version}"
             curl -sSL -o /usr/local/bin/minikube "https://storage.googleapis.com/minikube/releases/${requested_version}/minikube-linux-${architecture}"    
             MINIKUBE_VERSION="${requested_version}"
         fi
     fi
+    chmod 0755 /usr/local/bin/minikube
     if [ "$MINIKUBE_SHA256" = "automatic" ]; then
         MINIKUBE_SHA256="$(curl -sSL "https://storage.googleapis.com/minikube/releases/${MINIKUBE_VERSION}/minikube-linux-${architecture}.sha256")"
     fi

test/kubectl-helm-minikube/install_only_helm_fallback.sh

@@ -0,0 +1,122 @@
+#!/bin/bash
+set -e
+
+# Optional: Import test library
+source dev-container-features-test-lib
+HL="\033[1;33m"
+N="\033[0;37m"
+echo -e "\n👉${HL} helm version as installed by kubectl-helm-minikube feature${N}:"
+
+set +e
+    check "helm version" helm version
+set -e
+
+# Function to handle errors
+handle_error() {
+    local exit_code=$?
+    local line_number=$1
+    local command=$2
+    echo "Error occurred at line $line_number with exit code $exit_code in command $command"
+    exit $exit_code
+}
+trap 'handle_error $LINENO ${BASH_COMMAND%% *}' ERR
+echo "This is line $LINENO"
+
+## Check for fallback version installation instead of latest ( when artifact not found )
+architecture="$(uname -m)"
+case $architecture in
+    x86_64) architecture="amd64";;
+    aarch64 | armv8*) architecture="arm64";;
+    aarch32 | armv7* | armvhf*) architecture="arm";;
+    i?86) architecture="386";;
+    *) echo "(!) Architecture $architecture unsupported"; exit 1 ;;
+esac
+HELM_SHA256="${HELM_SHA256:-"automatic"}"
+HELM_GPG_KEYS_URI="https://raw.githubusercontent.com/helm/helm/main/KEYS"
+
+repo_url=https://api.github.com/repos/helm/helm/releases
+
+# Function to fetch the latest version of the plugin
+get_latest_version() {
+    curl -s "$repo_url/latest" | jq -r '.tag_name'
+}
+
+# Function to change the patch number in a semver version
+change_patch_number() {
+    local version="$1"  # Input version
+    local new_patch="$2"  # New patch number
+    # Extract major, minor, and current patch numbers
+    local major=$(echo "$version" | cut -d. -f1)
+    local minor=$(echo "$version" | cut -d. -f2)
+    local current_patch=$(echo "$version" | cut -d. -f3)
+    # Construct the new version with the updated patch number
+    local new_version="$major.$minor.$new_patch"
+    echo "$new_version"
+}
+
+# Function to fetch the previous version of the plugin
+get_previous_version() {
+    # this would del the assets key and then get the second encountered tag_name's value from the filtered array of objects
+    curl -s "$repo_url" | jq -r 'del(.[].assets) | .[1].tag_name' 
+}
+
+latest_version=$(get_latest_version)
+HELM_VERSION="$(change_patch_number ${latest_version} xyz)"
+echo -e "\n👉${HL} Trying to install HELM_VERSION = ${HELM_VERSION}${N}"; 
+sudo mkdir -p /tmp/helm
+helm_filename="helm-${HELM_VERSION}-linux-${architecture}.tar.gz"
+tmp_helm_filename="/tmp/helm/${helm_filename}"
+sudo curl -sSL "https://get.helm.sh/${helm_filename}" -o "${tmp_helm_filename}"
+sudo curl -sSL "https://github.com/helm/helm/releases/download/${HELM_VERSION}/${helm_filename}.asc" -o "${tmp_helm_filename}.asc"
+output=$(sudo cat /tmp/helm/"${helm_filename}.asc")
+if [[ "${output}" == *"Not Found"* ]]; then
+    echo -e "\n(!) Failed to fetch the latest artifacts for helm ${HELM_VERSION}..."
+    requested_version=$(get_previous_version)
+    echo -e "\nAttempting to install ${requested_version}"
+    helm_filename="helm-${requested_version}-linux-${architecture}.tar.gz"
+    tmp_helm_filename="/tmp/helm/${helm_filename}"
+    sudo curl -sSL "https://get.helm.sh/${helm_filename}" -o "${tmp_helm_filename}"
+    sudo curl -sSL "https://github.com/helm/helm/releases/download/${requested_version}/${helm_filename}.asc" -o "${tmp_helm_filename}.asc"
+    HELM_VERSION=${requested_version}
+fi
+export GNUPGHOME="/tmp/helm/gnupg"
+sudo mkdir -p "${GNUPGHOME}"
+sudo chmod 700 ${GNUPGHOME}
+sudo curl -sSL "${HELM_GPG_KEYS_URI}" -o /tmp/helm/KEYS
+sudo echo -e "disable-ipv6\n${GPG_KEY_SERVERS}" | sudo tee ${GNUPGHOME}/dirmngr.conf >/dev/null
+sudo gpg -q --import "/tmp/helm/KEYS"
+if ! sudo gpg --verify "${tmp_helm_filename}.asc" | sudo tee ${GNUPGHOME}/verify.log 2>&1; then
+    echo "Verification failed!"
+    sudo cat /tmp/helm/gnupg/verify.log
+    exit 1
+fi
+
+if [ "${HELM_SHA256}" = "automatic" ]; then
+    sudo curl -sSL "https://get.helm.sh/${helm_filename}.sha256" -o "${tmp_helm_filename}.sha256"
+    sudo curl -sSL "https://github.com/helm/helm/releases/download/${HELM_VERSION}/${helm_filename}.sha256.asc" -o "${tmp_helm_filename}.sha256.asc"
+    if ! sudo gpg --verify "${tmp_helm_filename}.sha256.asc" | sudo tee /tmp/helm/gnupg/verify.log 2>&1; then
+        echo "Verification failed!"
+        sudo cat /tmp/helm/gnupg/verify.log
+        exit 1
+    fi
+    HELM_SHA256="$(sudo cat "${tmp_helm_filename}.sha256")"
+fi
+
+([ "${HELM_SHA256}" = "dev-mode" ] || (sudo echo "${HELM_SHA256} *${tmp_helm_filename}" | sha256sum -c -))
+sudo tar xf "${tmp_helm_filename}" -C /tmp/helm
+sudo mv -f "/tmp/helm/linux-${architecture}/helm" /usr/local/bin/
+sudo chmod 0755 /usr/local/bin/helm
+sudo rm -rf /tmp/helm
+if ! type helm > /dev/null 2>&1; then
+    echo '(!) Helm installation failed!'
+    exit 1
+fi
+
+echo -e "\n👉${HL} helm version as installed by test for fallback${N}:"
+
+set +e
+    check "helm version" helm version
+set -e
+
+# Report result
+reportResults

test/kubectl-helm-minikube/install_only_kubectl_fallback.sh

@@ -0,0 +1,95 @@
+#!/bin/bash
+set -e
+
+# Function to handle errors
+handle_error() {
+    local exit_code=$?
+    local line_number=$1
+    local command=$2
+    echo "Error occurred at line $line_number with exit code $exit_code in command $command"
+    exit $exit_code
+}
+trap 'handle_error $LINENO ${BASH_COMMAND%% *}' ERR
+echo "This is line $LINENO"
+
+# Optional: Import test library
+source dev-container-features-test-lib
+
+HL="\033[1;33m"
+N="\033[0;37m"
+
+echo -e "\n👉${HL} kubectl version as installed by kubectl-helm-minikube feature${N}:"
+set +e
+    check "kubectl version" kubectl version --client
+set -e
+
+## Check for fallback version installation instead of latest ( when artifact not found )
+
+architecture="$(uname -m)"
+case $architecture in
+    x86_64) architecture="amd64";;
+    aarch64 | armv8*) architecture="arm64";;
+    aarch32 | armv7* | armvhf*) architecture="arm";;
+    i?86) architecture="386";;
+    *) echo "(!) Architecture $architecture unsupported"; exit 1 ;;
+esac
+
+KUBECTL_SHA256="${KUBECTL_SHA256:-"automatic"}"
+
+repo_url=https://api.github.com/repos/kubernetes/kubernetes/releases
+
+# Function to fetch the latest version of the plugin
+get_latest_version() {
+    curl -s "$repo_url/latest" | jq -r '.tag_name'
+}
+
+# Function to change the patch number in a semver version
+change_patch_number() {
+    local version="$1"  # Input version
+    local new_patch="$2"  # New patch number
+    # Extract major, minor, and current patch numbers
+    local major=$(echo "$version" | cut -d. -f1)
+    local minor=$(echo "$version" | cut -d. -f2)
+    local current_patch=$(echo "$version" | cut -d. -f3)
+    # Construct the new version with the updated patch number
+    local new_version="$major.$minor.$new_patch"
+    echo "$new_version"
+}
+
+# Function to fetch the previous version of the plugin
+get_previous_version() {
+    # this would del the assets key and then get the second encountered tag_name's value from the filtered array of objects
+    curl -s "$repo_url" | jq -r 'del(.[].assets) | .[1].tag_name' 
+}
+
+
+latest_version=$(get_latest_version)
+KUBECTL_VERSION="$(change_patch_number ${latest_version} xyz)"
+echo -e "\n👉${HL} Trying to install KUBECTL_VERSION = ${KUBECTL_VERSION}${N}"; 
+sudo curl -sSL -o /usr/local/bin/kubectl "https://dl.k8s.io/release/${KUBECTL_VERSION}/bin/linux/${architecture}/kubectl"
+if [ -e "/usr/local/bin/kubectl" ]; then
+    if grep -q "The specified key does not exist." "/usr/local/bin/kubectl"; then 
+        echo -e "\n(!) Failed to fetch the latest artifacts for kubectl ${KUBECTL_VERSION}..."
+        requested_version=$(get_previous_version)
+        echo -e "\nAttempting to install ${requested_version}"
+        sudo curl -sSL -o /usr/local/bin/kubectl "https://dl.k8s.io/release/${requested_version}/bin/linux/${architecture}/kubectl"
+        KUBECTL_VERSION="${requested_version}"
+    fi
+fi
+sudo chmod 0755 /usr/local/bin/kubectl
+if [ "$KUBECTL_SHA256" = "automatic" ]; then
+    KUBECTL_SHA256="$(sudo curl -sSL "https://dl.k8s.io/${KUBECTL_VERSION}/bin/linux/${architecture}/kubectl.sha256")"
+fi
+([ "${KUBECTL_SHA256}" = "dev-mode" ] || (sudo echo "${KUBECTL_SHA256} */usr/local/bin/kubectl" | sha256sum -c -))
+if ! type kubectl > /dev/null 2>&1; then
+    echo '(!) kubectl installation failed!'
+    exit 1
+fi
+
+echo -e "\n👉${HL} kubectl version as installed by this test for fallback installation${N}:"
+set +e
+    check "kubectl version" kubectl version --client
+set -e
+
+# Report result
+reportResults

test/kubectl-helm-minikube/install_only_minikube_fallback.sh

@@ -0,0 +1,95 @@
+#!/bin/bash
+set -e
+
+# Function to handle errors
+handle_error() {
+    local exit_code=$?
+    local line_number=$1
+    local command=$2
+    echo "Error occurred at line $line_number with exit code $exit_code in command $command"
+    exit $exit_code
+}
+trap 'handle_error $LINENO ${BASH_COMMAND%% *}' ERR
+echo "This is line $LINENO"
+
+# Optional: Import test library
+source dev-container-features-test-lib
+
+HL="\033[1;33m"
+N="\033[0;37m"
+
+echo -e "\n👉${HL} minikube version as installed by kubectl-helm-minikube feature${N}:"
+set +e
+    check "minikube version" minikube version
+set -e
+
+## Check for fallback version installation instead of latest ( when artifact not found )
+
+architecture="$(uname -m)"
+case $architecture in
+    x86_64) architecture="amd64";;
+    aarch64 | armv8*) architecture="arm64";;
+    aarch32 | armv7* | armvhf*) architecture="arm";;
+    i?86) architecture="386";;
+    *) echo "(!) Architecture $architecture unsupported"; exit 1 ;;
+esac
+
+MINIKUBE_SHA256="${MINIKUBE_SHA256:-"automatic"}"
+
+repo_url=https://api.github.com/repos/kubernetes/minikube/releases
+
+# Function to fetch the latest version of the plugin
+get_latest_version() {
+    curl -s "$repo_url/latest" | jq -r '.tag_name'
+}
+
+# Function to change the patch number in a semver version
+change_patch_number() {
+    local version="$1"  # Input version
+    local new_patch="$2"  # New patch number
+    # Extract major, minor, and current patch numbers
+    local major=$(echo "$version" | cut -d. -f1)
+    local minor=$(echo "$version" | cut -d. -f2)
+    local current_patch=$(echo "$version" | cut -d. -f3)
+    # Construct the new version with the updated patch number
+    local new_version="$major.$minor.$new_patch"
+    echo "$new_version"
+}
+
+# Function to fetch the previous version of the plugin
+get_previous_version() {
+    # this would del the assets key and then get the second encountered tag_name's value from the filtered array of objects
+    curl -s "$repo_url" | jq -r 'del(.[].assets) | .[1].tag_name' 
+}
+
+
+latest_version=$(get_latest_version)
+MINIKUBE_VERSION="$(change_patch_number ${latest_version} xyz)"
+echo -e "\n👉${HL} Trying to install MINIKUBE_VERSION = ${MINIKUBE_VERSION}${N}"; 
+sudo curl -sSL -o /usr/local/bin/minikube "https://storage.googleapis.com/minikube/releases/${MINIKUBE_VERSION}/minikube-linux-${architecture}"    
+if [ -e "/usr/local/bin/minikube" ]; then
+        if grep -q "The specified key does not exist." "/usr/local/bin/minikube"; then 
+            echo -e "\n(!) Failed to fetch the latest artifacts for minikube ${MINIKUBE_VERSION}..."
+            requested_version=$(get_previous_version "${repo_url}")
+            echo -e "\nAttempting to install ${requested_version}"
+            sudo curl -sSL -o /usr/local/bin/minikube "https://storage.googleapis.com/minikube/releases/${requested_version}/minikube-linux-${architecture}"    
+            MINIKUBE_VERSION="${requested_version}"
+        fi
+fi
+sudo chmod 0755 /usr/local/bin/minikube
+if [ "$MINIKUBE_SHA256" = "automatic" ]; then
+    MINIKUBE_SHA256="$(sudo curl -sSL "https://storage.googleapis.com/minikube/releases/${MINIKUBE_VERSION}/minikube-linux-${architecture}.sha256")"
+fi
+ ([ "${MINIKUBE_SHA256}" = "dev-mode" ] || (sudo echo "${MINIKUBE_SHA256} */usr/local/bin/minikube" | sha256sum -c -))
+    if ! type minikube > /dev/null 2>&1; then
+        echo '(!) minikube installation failed!'
+        exit 1
+    fi
+
+echo -e "\n👉${HL} minikube version as installed by this test for fallback installation${N}:"
+set +e
+    check "minikube version" minikube version
+set -e
+
+# Report result
+reportResults