Make dev-container-features-test-lib script POSIX compliant (fixes #438) #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
Thank you! Have you by chance run against a repo that has a lot of test scripts, like https://github.com/devcontainers/features? |
|
I have run tests against devcontainers/features using the version of the devcontainers CLI built from this PR. There are a few failures but they all seem to be because upstream repos have been removed or other failures unrelated to the changes in this PR. https://github.com/garymacindoe/features/actions/runs/13408523890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rewritten the
dev-container-features-test-libscript included in thedevcontainerCLI to be POSIX-compliant (using shellcheck).This fixes tests against images where the default shell is not Bash (such as in #438).