Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features package <...> command #93

Merged
merged 18 commits into from
Aug 8, 2022
Merged

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Jul 29, 2022

Implements the packaging step of the proposed feature specification.

This PR also refactors the features <test> .. command into it's own file for tidyness.

@joshspicer joshspicer requested review from a team and removed request for alexdima, chrmarti and edgonmsft July 29, 2022 17:56
Copy link
Contributor

@jkeech jkeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this command! It seems like this will be really helpful for feature authors to package and distribute their features.

I left a few comments/suggestions.

- default output to ./output and guard against overwritting
- default example project in vscode launch config
@joshspicer joshspicer requested a review from alexdima August 1, 2022 17:29
@joshspicer joshspicer requested a review from a team August 1, 2022 19:48
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I left a few comments.

@joshspicer joshspicer requested review from jkeech and alexdima August 5, 2022 16:57
@joshspicer joshspicer requested a review from chrmarti August 8, 2022 14:37
@joshspicer joshspicer merged commit 6d4298a into main Aug 8, 2022
@joshspicer joshspicer deleted the jospicer/package-features branch August 8, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants