Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[features test cmd] Add --remote-env flag #451

Closed
wants to merge 2 commits into from

Conversation

joshspicer
Copy link
Member

ref: #448

Provide a way for users to pass environment variables when invoking the test command (using the standardized --remote-env flag). This is particularly useful now that Features can contribute lifecycle scripts, so things like secrets can be feasibly utilized by Features.

See the regression test for how this would be used.

@joshspicer joshspicer requested a review from a team as a code owner March 15, 2023 23:39
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For secrets we might want to follow what we come up with for up and other commands. (E.g., this could be --secret-env-file.) Are there other use cases for --remote-env?

@joshspicer
Copy link
Member Author

That's fair - perhaps we put this on the backburner until we have a solution for passing secrets to up.

@joshspicer joshspicer closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants