Fix "Failed to fetch local disk feature on Windows" #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshspicer
changed the title
chrmarti
requested changes
Dec 23, 2022
chrmarti
requested changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #321
Also adds in a test to prevent regression via a new Windows-based test workflow.
NOTE: Refactoring/updating the test suite will need to be done incrementally to get 100% of the test suite running (at that point we can remove the new workflow and matrix running the tests against
ubuntu-latestandwindows-latestin a single workflow)shelljsis added a dev dependency to abstract shell commands when running on linux/windows (see this closed PR for an example of how it will be used: #177)