getCollectionRef() to centralize validating Collection identifier
#303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #293 and will close devcontainers/action#103.
This change now generates the
OCICollectionRefobject in a centralized function, just likeOCIRef. It also uses the same regex that OCIRef uses for validation to validate the path is spec compliant.Fixes the 404 seen in this action run when pushing the metadata collection artifact to registry (note the Capital Letters in the repo name). Crucially, the identifier is now fully downcased, like done in #293.
Unit tests added to prevent regressions.
Successful run of the publish command: