Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainer features test documentation #219

Merged
merged 4 commits into from
Nov 1, 2022

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Oct 10, 2022

Relevant: #139
closes #216

Documentation for the devcontainer features test command under active development. Feedback/clarifications welcomed!

Would love feedback from you all @AlexanderLanin / @snebjorn

@joshspicer joshspicer requested a review from jungaretti October 10, 2022 17:58
Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Left a few minor comments.

Copy link
Contributor

@AlexanderLanin AlexanderLanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid I have some additional remarks. But this PR will really help a lot.

Co-authored-by: JP Ungaretti <19893438+jungaretti@users.noreply.github.com>
Co-authored-by: Brigit Murtaugh <brigit.murtaugh@microsoft.com>
Co-authored-by: Alexander Lanin <alex@lanin.de>
chrmarti
chrmarti previously approved these changes Oct 11, 2022
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a few comments for consideration.

@joshspicer joshspicer merged commit 0de50fa into main Nov 1, 2022
@joshspicer joshspicer deleted the joshspicer/features-test-commmand-docs branch November 1, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs for devcontainer features test <...> command
5 participants