Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds templates publish command #198

Merged
merged 4 commits into from
Sep 30, 2022
Merged

adds templates publish command #198

merged 4 commits into from
Sep 30, 2022

Conversation

samruddhikhandale
Copy link
Member

Based on top of samruddhikhandale/templates-package branch.

Adds a template publish CLI command according to the spec

image

Sample - publishing templates

image

image

image

@samruddhikhandale samruddhikhandale requested a review from a team as a code owner September 29, 2022 22:24
@samruddhikhandale samruddhikhandale changed the title adds templates package command adds templates publish command Sep 29, 2022
chrmarti
chrmarti requested changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one comment to avoid tmp folder conflicts.

Base automatically changed from samruddhikhandale/templates-package to main September 30, 2022 15:06
chrmarti
chrmarti approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samruddhikhandale samruddhikhandale merged commit 398154f into main Sep 30, 2022
@samruddhikhandale samruddhikhandale deleted the samruddhikhandale/templates-publish branch September 30, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrmarti chrmarti chrmarti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samruddhikhandale @chrmarti