Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto mapping feature ids from old shorthand syntax to devcontainers/features #100

Merged
merged 12 commits into from
Aug 12, 2022
Merged

Auto mapping feature ids from old shorthand syntax to devcontainers/features #100

merged 12 commits into from
Aug 12, 2022

Conversation

samruddhikhandale
Copy link
Member

@samruddhikhandale samruddhikhandale commented Aug 2, 2022 •
edited
Loading

Addresses - #88 and #88

Mapping of old shorthand syntax of features

  • Migrated feature ids are mapped to ghcr.io/devcontainers/features/${id}:1
  • Renamed feature ids are mapped to ghcr.io/devcontainers/features/${id}:1
  • Deprecated feature ids are kept as it is

Added tests?
Yes!

Dependency -
Should not be merged until we have started pointing people to new repository and pulled off the plug from https://github.com/microsoft/vscode-dev-containers

@samruddhikhandale samruddhikhandale mentioned this pull request Aug 2, 2022
Open
Base automatically changed from oci to main August 3, 2022 14:18
@samruddhikhandale samruddhikhandale marked this pull request as ready for review August 3, 2022 19:05
@samruddhikhandale samruddhikhandale requested a review from a team as a code owner August 3, 2022 19:05
@samruddhikhandale samruddhikhandale changed the title adds backward compatibility Adds backward compatibility - Auto mapping feature ids from old shorthand syntax Aug 3, 2022
@samruddhikhandale samruddhikhandale changed the title Adds backward compatibility - Auto mapping feature ids from old shorthand syntax Auto mapping feature ids from old shorthand syntax to devcontainers/features Aug 10, 2022
chrmarti
chrmarti requested changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing approval to discuss the option to let the new functionality get more testing before we redirect existing configurations to use it.

chrmarti
chrmarti previously approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving since Remote-Containers stable version 0.245.0 is released. (As discussed.)

@chrmarti chrmarti merged commit 1f35c44 into main Aug 12, 2022
@chrmarti chrmarti deleted the samruddhikhandale/add-features-backward-comp branch August 12, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshspicer joshspicer joshspicer left review comments

@chrmarti chrmarti chrmarti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samruddhikhandale @chrmarti @joshspicer @edgonmsft