Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] remove test containers after every run #409

Open
Tracked by #139
akhildevelops opened this issue Feb 10, 2023 · 0 comments
Open
Tracked by #139

[feature] remove test containers after every run #409

akhildevelops opened this issue Feb 10, 2023 · 0 comments
Labels
feature-request New feature or request

Comments

@akhildevelops
Copy link

akhildevelops commented Feb 10, 2023 •
edited
Loading

I ❤️ the tool thanks for creating it.

I observed that test containers don't stop and removed after every completion of tests.

After a successful run:

🏃 Starting test(s)...

🧪 Starting 'android-cli' tests...
🧪 Executing scenarios for feature 'android-cli'...
⚠️ No scenario file found at '/workspaces/devcontainer-features/test/android-cli/scenarios.json'. Skipping...



  ================== TEST REPORT ==================
✅ Passed:      'android-cli'

I observe the test containers still run:

node ➜ /workspaces/devcontainer-features/test/color (main) $ docker ps
CONTAINER ID   IMAGE                                                         COMMAND                  CREATED         STATUS         PORTS     NAMES
32aa248c7dc0   vsc-1676027268210-864360691c93743c8b0c629ee643756c-features   "/bin/sh -c 'echo Co…"   9 seconds ago   Up 7 seconds             flamboyant_moore
@joshspicer joshspicer mentioned this issue Mar 15, 2023
Open
17 tasks
joshspicer added a commit that referenced this issue Mar 15, 2023
@joshspicer
[features test cmd] Automatically clean up test containers
59f3464 
ref: #409
@joshspicer joshspicer mentioned this issue Mar 15, 2023
Merged
joshspicer added a commit that referenced this issue Apr 14, 2023
@joshspicer
[features test cmd] Automatically clean up test containers (#450)
2c28419 
* [features test cmd] Automatically clean up test containers

ref: #409

* add test

* re-remove skipImageMetadata flag
@joshspicer joshspicer removed their assignment Jul 23, 2024
@chrmarti chrmarti added the feature-request New feature or request label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akhildevelops @chrmarti @joshspicer