Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh: refactor community files #222

Merged
merged 3 commits into from
Apr 17, 2023
Merged

gh: refactor community files #222

merged 3 commits into from
Apr 17, 2023

Conversation

SauravMaheshkar
Copy link
Contributor

This PR aims to move the CODEOWNERS and CONTRIBUTING.md file from the root of the directory to the .github/ directory. Github looks for a contribution guideline file in the following order: .github dir > project root > docs dir (source). Moving the file to the .github/ dir leads to a minimal project structure without any functional change.

@SauravMaheshkar SauravMaheshkar requested review from a team and stuartleeks as code owners March 3, 2023 23:54
@stuartleeks
Copy link
Collaborator

I'm happy to move CODEOWNERS but my personal feeling is that having CONTRIBUTING.md in the root aids discoverability.

@chrmarti - what are your thoughts?

@SauravMaheshkar
Copy link
Contributor Author

of course, I'll reiterate after feedback.

@chrmarti
Copy link
Collaborator

I'm happy to move CODEOWNERS but my personal feeling is that having CONTRIBUTING.md in the root aids discoverability.

Makes sense! 👍

@SauravMaheshkar
Copy link
Contributor Author

SauravMaheshkar commented Mar 10, 2023 •
edited
Loading

I'm happy to move CODEOWNERS but my personal feeling is that having CONTRIBUTING.md in the root aids discoverability.

Makes sense! 👍

@stuartleeks Addressed in 337124e

@SauravMaheshkar
Copy link
Contributor Author

Gentle ping @stuartleeks @chrmarti

jkeech
jkeech approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@jkeech jkeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree with moving CODEOWNERS and not the CONTRIBUTING.md guide.

@jkeech
Copy link
Contributor

jkeech commented Apr 17, 2023

/test

@github-actions
Copy link

🤖 pr-bot 🤖

⚠️ When using /test on external PRs, the SHA of the checked commit must be specified

(in response to this comment from @jkeech)

@jkeech
Copy link
Contributor

jkeech commented Apr 17, 2023

/test-force-approve

CODEOWNERS update only

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 337124e)

(in response to this comment from @jkeech)

@jkeech jkeech merged commit 3514d19 into devcontainers:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkeech jkeech jkeech approved these changes

@stuartleeks stuartleeks Awaiting requested review from stuartleeks stuartleeks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SauravMaheshkar @stuartleeks @chrmarti @jkeech