Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try not to show infinite error dialogs #212

Closed
wants to merge 2 commits into from
Closed

Conversation

pde
Copy link

@pde pde commented Jan 22, 2022

This is a start on resolving #210, but probably not ready yet.

@pde
Copy link
Author

pde commented Jan 22, 2022

At one point I saw a segfault when disconnecting an iphone with this branch:

./droidcam
Video: /dev/video0
Audio: hw:1,1,0

(droidcam:1741809): Gdk-CRITICAL **: 11:04:52.824: gdk_window_thaw_toplevel_updates: assertion 'window->update_and_descendants_freeze_count > 0' failed
Segmentation fault

unsure of likely causes and out of time to debug for now!

@aramg
Copy link
Collaborator

aramg commented Jan 22, 2022

Are you able to reproduce the segfault reliably, and get a gdb backtrace? Would need that to look into it.

As for the dialog spam, I've pushed some changes https://github.com/dev47apps/droidcam/tree/dev.
Will test and update the client next week, as time permits (unable to at the moment)

@pde
Copy link
Author

pde commented Jan 25, 2022

I wasn't immediately able to reproduce at all; will try running this version as my actual camera for a while and see what happens...

@pde
Copy link
Author

pde commented Feb 1, 2022

@aramg your approach in the dev branch of turning off all the errors seems a bit aggressive in response to the spam problem? To me it seems to depend on whether there's a chance all those different errors ever help the user figure out why things aren't working (I'm sure you have some experience with that ;). If they do, you could consider either having one error dialog display and then that's enough (as I tried in this PR), or moving the errors to console output or a log UI pane, so people can dig in there if they need to.

@aramg
Copy link
Collaborator

aramg commented Feb 2, 2022

The errors aren't being turned off? They've been moved out into the main app code (droidcam/-cli).
The underlying code shouldn't be interfering with the UI.

@aramg
Copy link
Collaborator

aramg commented Feb 2, 2022

@pde the dev branch is updated with what should fix the spam if you yank the cable.
Errors should still be displayed if the initial connection fails.

@aramg
Copy link
Collaborator

aramg commented Feb 14, 2022

v1.8.2 released here on github

@aramg aramg closed this Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants