Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test mechanisms #169

Merged
merged 26 commits into from
Jan 27, 2019
Merged

Update test mechanisms #169

merged 26 commits into from
Jan 27, 2019

Conversation

mcgege
Copy link
Member

@mcgege mcgege commented Jan 17, 2019 •
edited
Loading

  • Use standard PDK routines (Update pdk #142 )
  • lint and unit tests implemented
    • local: pdk validate, pdk test unit
    • remote: Travis
  • integration tests with docker (local + remote)

mcgege added 17 commits January 9, 2019 08:52
@mcgege
pdk update (to 1.8.0)
c14df04 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
pdk sync fixes
a5a82a1 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
changelog generator settings
82e0822 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Use our PDK template
10ea506 
changelog_generator config

Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Cleanup (hopefully) unused files
78717ae 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Add missing fact for unit tests
f7b008a 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Temporary disable test Style/WordArray
6c0b475 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Use recommended built-in mocking library
7a1bf37 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Add test branch to Travis
111d122 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Disable automatic deployment for now
6aa8df2 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Remove rbenv pattern
bb96141 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Kitchen integration tests with (local?) docker
bd566e8 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Merge branch 'master' into pdk180
ad166df
@mcgege
Make lint happy
5b2c039 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Revert Puppetfile to static modules (check:symlinks)
ec14095 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Improvements on local (docker) kitchen tests
82abacd 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Speedup kitchen tests with kitchen-sync
ec62b90 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege mcgege mentioned this pull request Jan 17, 2019
Closed
mcgege added 4 commits January 17, 2019 10:30
@mcgege
Delete testing branch reference in travis config
f26f469 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Run integration tests also on Travis CI
16befc5 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Small fix (Ubuntu)
cfb7621 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Ubuntu fix
db0b4e3 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege mcgege mentioned this pull request Jan 17, 2019
Closed
mcgege added 3 commits January 18, 2019 12:04
@mcgege
Use correct puppet repo on Centos 7
2d5548d 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Add kitchen test for OpenSUSE
f79293e 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Add more distros
16ee4ae 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege mcgege mentioned this pull request Jan 19, 2019
Closed
@mcgege
Refine used Puppet repos
8df6672 
Add integration tests for Puppet 6

Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege mcgege mentioned this pull request Jan 20, 2019
Closed
@mcgege
update metadata (works with Puppet 6, Debian 9)
31466dc 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege mcgege added this to the 2.2.0 milestone Jan 27, 2019
@mcgege mcgege merged commit e7e5c09 into master Jan 27, 2019
@mcgege mcgege deleted the pdk180 branch January 27, 2019 09:05
artem-sidorenko
artem-sidorenko reviewed Jan 29, 2019
View reviewed changes
kitchen.yml Show resolved Hide resolved
test/integration/docker-linux-baseline/controls/tests.rb
# skip auditd tests, we do not have any implementation for audit management yet
skip_control 'package-08'

# docker environment - skip all sysctl tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcgege Hm. This is strange, the https://github.com/dev-sec/linux-baseline/pull/91/files should basically do the auto-detection here and exclude specific tests for container environments. Did you have any issues with it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, had some problems here, but I cannot remember the details right now :-)
Have to recheck this ...

.sync.yml Show resolved Hide resolved
enemarke pushed a commit to enemarke/puppet-os-hardening that referenced this pull request Feb 2, 2019
@mcgege @enemarke
Update test mechanisms (dev-sec#169)
365b91c 
* PDK update (to 1.8.0) with own template
* Use standard PDK routines (dev-sec#142 )
* lint and unit tests implemented
   * local: pdk validate, pdk test unit
   * remote: Travis
* Kitchen integration tests with docker (local + remote)
* Add integration tests for Puppet 6
* Update metadata (works with Puppet 6, Debian 9)

Signed-off-by: Michael Geiger <info@mgeiger.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-sidorenko artem-sidorenko artem-sidorenko left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mcgege @artem-sidorenko @chris-rock