-
Notifications
You must be signed in to change notification settings - Fork 16
Home
2014 May 14 George Kiagiadakis finished reviewing, fixing up, and merging my port attempt with the work that had been done in freedesktop master.
Master in this repository should now mirror whats at http://cgit.freedesktop.org/gstreamer/qt-gstreamer/
Remaining Issues as described by the upstream George.
-
The two below make me wonder whether we actually need QGst::Memory.. maybe it can be removed and added in a later release properly (it's not very useful tbh)
- GstMemory requires proper GstAllocator wrapper (and Memory::create(size) really belongs to the allocator class btw)
- Buffer::peekMemory() -> I don't like the name because peek methods in C infer that there is no increase on the reference count, but in our case the reference count is increased because of the smart pointer.
-
ElementFactory::metadata() needs a design choice on how to represent the constant strings. I think that static QString/QByteArray instances - which would be initialized in the .cpp with the C macros - would work, but not sure what is the best choice (QString? QByteArray? const char*?). This thing with the multiple string classes has always puzzled me in qt-gstreamer.
-
const StructurePtr vs StructureConstPtr...
-
What I said previously about the TagList becoming a subclass of MiniObject (but we can also ignore it. it works as it is)
- Wrapping of MiniObjects can now be done in a better way, like the GObject wrapping, since MiniObjects now support qdata and weak references, but it's a bit tricky to do it right. (see docs/design/wrap.txt for more info)
- This release actually introduces a QtQuick2 video sink (it was never part of a release in the 0.10 series) and there is missing documentation about it.
- The recorder example needs a rewrite
- The code of the gst elements (qtvideosink and friends) could be simplified/unified a bit... I have some ideas, this will be definitely done in another release.