fix: remove unused languages from codeeditor #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove @uiw/codemirror-extensions-langs: Extra languages were not accessible and only served to bloat build size when consuming apps import the code editor * use new yaml languagesupport: the old yaml package and the one included in the extension module did not support code folding. * reuse github flavored markdown instead of commonmark: github flavored markdown highlights regular links and tables.
✅ Deploy Preview for hew-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=======================================
Coverage 82.78% 82.78%
=======================================
Files 49 49
Lines 6482 6482
Branches 454 454
=======================================
Hits 5366 5366
Misses 1116 1116 ☔ View full report in Codecov by Sentry. |
thiagodallacqua-hpe
approved these changes
Sep 5, 2024
ashtonG
force-pushed
the
bug/remove-extra-languages
branch
from
4e9fd39 to
f150486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove @uiw/codemirror-extensions-langs: Extra languages were not accessible and only served to bloat build size when consuming apps import the code editor by two megabytes.
use new yaml languagesupport: the old yaml package and the one included in the extension module did not support code folding.
reuse github flavored markdown instead of commonmark: github flavored markdown highlights regular links and tables.