Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node version to active LTS (DET-7046) #3932

Merged
merged 8 commits into from
Apr 26, 2022
Merged

chore: update node version to active LTS (DET-7046) #3932

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cc690c8
use lts node and npm versions
johnkim-det Apr 18, 2022
24d0328
lockfile
johnkim-det Apr 18, 2022
8ef644d
legacy-peer-deps
johnkim-det Apr 18, 2022
8616ebb
use craco-sass-resources-loader fork
johnkim-det Apr 18, 2022
c72d642
typescript error
johnkim-det Apr 20, 2022
7c38676
Revert "use craco-sass-resources-loader fork"
johnkim-det Apr 20, 2022
c924ce5
version numbers
johnkim-det Apr 20, 2022
18c6bb5
require node 16.13
johnkim-det Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,7 +1141,7 @@ jobs:

lint-react:
docker:
- image: cimg/node:14.16
- image: cimg/node:16.14.2
steps:
- checkout
- react-get-deps
Expand All @@ -1153,7 +1153,7 @@ jobs:
type: boolean
default: false
docker:
- image: cimg/node:14.16
- image: cimg/node:16.14.2
resource_class: large
steps:
- checkout
Expand All @@ -1171,7 +1171,7 @@ jobs:

test-unit-react:
docker:
- image: cimg/node:14.16
- image: cimg/node:16.14.2
environment:
CI: "true"
resource_class: large
Expand All @@ -1186,7 +1186,7 @@ jobs:

build-storybook:
docker:
- image: cimg/node:14.16
- image: cimg/node:16.14.2
steps:
- checkout
- react-get-deps
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ git clone git@github.com:determined-ai/determined.git

- Go (>= 1.18)
- Python (>= 3.6, <= 3.9)
- Node (>= 14.16)
- NPM (>= 6.12)
- Node (>= 16.14)
hamidzr marked this conversation as resolved.
Show resolved Hide resolved
- NPM (>= 8.7)
- Docker (>= 19.03)
- Helm (>= 3.0.0)
- Protoc (>= 3.0)
Expand Down
1 change: 1 addition & 0 deletions webui/react/.npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
legacy-peer-deps=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be ideal to see if we can upgrade our packages so we don't need this but it sounds like this is a good step forward and strictly a win.

https://github.blog/2021-02-02-npm-7-is-now-generally-available/#peer-dependencies

You have the option to retry with --force to bypass the conflict or --legacy-peer-deps command to ignore peer dependencies entirely (this behavior is similar to versions 4-6).

2 changes: 1 addition & 1 deletion webui/react/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14.16.0
16.14.2
Loading