Add PLTypeSplitSymbols #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h67ma
added a commit
to h67ma/thumb-key
that referenced
this pull request
Sep 10, 2024
Shifted swipe type is TWO_WAY_HORIZONTAL, which makes it impossible to input '`' and '"'. Change it to FOUR_WAY_CROSS. Fixes: dea3d03 ("Add PLTypeSplitSymbols (dessalines#851)") Signed-off-by: h67ma <szycikm@gmail.com>
dessalines
pushed a commit
that referenced
this pull request
Sep 10, 2024
* PLTypeSplitSymbols: Fix shifted input of tilde and double quote Shifted swipe type is TWO_WAY_HORIZONTAL, which makes it impossible to input '`' and '"'. Change it to FOUR_WAY_CROSS. Fixes: dea3d03 ("Add PLTypeSplitSymbols (#851)") Signed-off-by: h67ma <szycikm@gmail.com> * PLTypeSplit*: Move a few letters to more sensible places Letter positions in PLTypeSplit and PLTypeSplitSymbols layouts are based on QWERTY, however a few letters reside in unexpected places, which makes writing a bit unintuitive. The middle row is also unbalanced - left half has 4 letters, while right side has 8 (granted, these are less frequently used ones). Move a few letters to more familiar positions: * Move G to left half * Move F to left half * Move J more to the left * Move ` and ~ elsewhere to make place for F and G (only PLTypeSplitSymbols) Note that one letter is still in a "wrong" place: D, which should be in the left half. However, it can't be moved as it's more popular than all letters in the right side middle row (except K), and A and S are more popular and they already occupy both available slots in the left half. Signed-off-by: h67ma <szycikm@gmail.com> * PLTypeSplitSymbols: Add more symbols Improve the layout by adding more symbols and tweaking the positions of present ones: * Add missing symbols: '#', '$', '%', '^', '&', '|' * Rearrange some symbols to make '?' easier to type and create some nice pairs (like ':' and ';', '\' and '/') * Replace the middle space with symbol selector, which inputs '.' without swipe (why would you need two spaces anyway?) * Replace the bottom space with a symbol-less one, since all symbols are now nicely grouped on the key above * Move the funny face emoji macro thing (?) to numeric keyboard to make place for standard characters. This affects all layouts that use TYPESPLIT_NUMERIC_KEYBOARD (and FRENCH_TYPESPLIT_NUMERIC_KEYBOARD too, for consistency) Signed-off-by: h67ma <szycikm@gmail.com> * TypeSplit: Swap swipe actions on numeric/emoji keys Swipe actions are hard to input on keys that are in the corner of the screen. In *TypeSplit layouts, bottom left corner is occupied by numeric keyboard switch key, which also has some useful text edit options on swipes (copy, paste, undo, etc.). In contrast, the emoji key has some rather uncommon actions on it (settings, input method/layout switcher). Swap the two swipe sets in order to bring the more useful actions to a much more convenient place. Main key functions are preserved (emoji, numeric keyboard switcher). Because in the numeric layout the swipe set has also changed, add the now-missing text edit swipes to one of the spaces and remove the settings action (now covered by bottom-left key). These changes affect all *TypeSplit layouts. Signed-off-by: h67ma <szycikm@gmail.com> * NumericTypeSplit: Remove shift Remove shift mode from NumericTypeSplit and NumericFrenchTypeSplit numpads, as it doesn't have any effect there. Signed-off-by: h67ma <szycikm@gmail.com> * NumericTypeSplit: reorganize interpunction and symbols On *TypeSplit keyboards, the numeric keyboard is often the only way to input most special symbols. However, those symbols are poorly organized. The ones commonly found on the numeric row ('!', '@', '#', ...) are found on seemingly random digit keys, making it hard to localize them. Furthermore, the layout is cluttered, with many symbols packed on a single key (in some cases up to 7 symbols on one key). Move numeric row symbols to keys where the user would be expecting them: '!' to 1, '@' to 2, '#' to 3, etc., with the exception of '(', which is left on the side of the keyboard, so that the brackets lie in symmetrical places. Each of the 8 symbols is activated by swiping towards 5 (and '%' is swipe down). Move a few symbols to one of the currently empty spaces on the left side to declutter the numpad area. Remove ',' and '.' from numpad, as they are already available on the right side of the layout. Move a few other other symbols to be more evenly spaced out and easier to access. Signed-off-by: h67ma <szycikm@gmail.com> --------- Signed-off-by: h67ma <szycikm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a few symbols i commonly use; maybe someone will also want to use it
because making a custom layout is pretty annoyingi may add things later if i missed something, but this is mostly for personal use