Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Keyboard layout English Spanish Catalan #826

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Conversation

Norgus
Copy link
Contributor

@Norgus Norgus commented Apr 3, 2024

I've added a layout based on English thumbkey layout supporting Spanish & Catalan. Inspiration drawn from ES-CA thumbkey layout.

I think I've done it right, but it's fairly unfamiliar stuff to me.
Reason for this layout is I already 'mapped' the English layout in my head but want to be able to type the Catalan and Spanish accents without stumbling.

…talan. Inspiration drawn from ES-CA thumbkey layout.
@Norgus Norgus requested a review from dessalines as a code owner April 3, 2024 11:07
Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run ./gradlew formatKotlin to pass lint.

@Norgus
Copy link
Contributor Author

Norgus commented Apr 4, 2024

Run ./gradlew formatKotlin to pass lint.

I don't know what I'm doing with this, but I tried with the following failure.

............10%............20%.............30%............40%.............50%............60%.............70%............80%.............90%............100%

Welcome to Gradle 8.4!                                                           
Here are the highlights of this release:
 - Compiling and testing with Java 21
 - Faster Java compilation on Windows
 - Role focused dependency configurations creation

For more details see https://docs.gradle.org/8.4/release-notes.html

To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/8.4/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
Daemon will be stopped at the end of the build
Calculating task graph as no configuration cache is available for tasks:

FAILURE: Build failed with an exception.                                         
* What went wrong:
Could not open cp_settings generic class cache for settings file '/home/norgus/Documents/catala learning/thumbkey/thumb-key/settings.gradle' (/home/norgus/.gradle/caches/8.4/scripts/6bnzncufsmj0z3t785zjujf7v).
> BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 66

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.                                          > Get more help at https://help.gradle.org.                                      
BUILD FAILED in 13s                                                              Configuration cache entry stored.```

@dessalines
Copy link
Owner

It's alright, I'll fix the formatting issues shortly.

@dessalines dessalines enabled auto-merge (squash) April 4, 2024 18:22
@dessalines dessalines merged commit 913035e into dessalines:main Apr 4, 2024
1 check passed
@Norgus
Copy link
Contributor Author

Norgus commented Apr 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants