-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add layout for English and French #665
Conversation
641da95
to
89383a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No probs, glad ppl find thumbkey useful!
Also you might need to run ./gradlew formatKotlin
to pass lint.
), | ||
) | ||
|
||
val KB_EN_FR_NUMERIC = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything missing from the general numeric keyboard that we could add? Or should this keyboard be for all french keyboards?
If it should be for all french layouts, I'd prefer this be added to the common.kt
rather than this file.
If you'd only like this numeric keyboard to be for this one, that's also fine to leave here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, went with english français symbols messagease
;-)
There is not much specific to French on the numeric keyboard, it would be a personal preference whether to include some symbols on the general numeric one. There is a screenshot in the PR's description, let me know if you'd like me to add some ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case since its mostly personal preference for a few extra symbols, I'd say its fine to leave here :)
``` ┌───────┬───────┬───────┐ │  │ │ Î │ │ A │ N !│? I │ │ À V│ L │X Ï │ ├───────┼───────┼───────┤ │ Û Ç│Q H P│ ▢ │ │( U K│C O B│M R )│ │ ' Ù│G D J│ ▢ │ ├───────┼───────┼───────┤ │ Ô Y│È W É│F │ │ T -│Ê E Z│Ë S │ │ │, . :│; │ └───────┴───────┴───────┘ ┌───────┬───────┬───────┐ │ │` ^ ´│² ≈ ³│ │≤ 1 │+ 2 !│? 3 ≥│ │ $ €│/ * \│ = │ ├───────┼───────┼───────┤ │{ ✓│↔ ↑ ↕│ ½ }│ │( 4 │← 5 →│¼ 6 )│ │[ ' ✗│ ↓ _│@ ¾ ]│ ├───────┼───────┼───────┤ │~ " °│· • –│— & |│ │< 7 -│ 8 %│# 9 >│ │« ↹│, . :│; »│ └───────┴───────┴───────┘ ```
89383a9
to
91ab77f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I'll trigger another build to make sure it passes.
Congrats on making this project 🥳 And thank you 🙏
Here's the layout that I've been using with MessagEase for five years. It's especially useful when typing English and French everyday.
Add layout for English and French