Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unit test & fix bugs #220

Merged
merged 31 commits into from
Apr 11, 2023
Merged

feat: add unit test & fix bugs #220

merged 31 commits into from
Apr 11, 2023

Conversation

beyond009
Copy link
Contributor

Description

  • add uint test for ERC5727Example.sol
  • remove access control
  • fix _spendAllowance in ERC3525.sol
  • fix signature verify bug
  • fix _beforeValueTransfer in ERC3525SlotEnumerable.sol
  • fix tokenOfOwnerByIndex in ERC721Enumerable.sol

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@beyond009 beyond009 requested a review from AustinZhu April 11, 2023 07:32
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 96.96% and project coverage change: +61.31 🎉

Comparison is base (f957c3c) 0.00% compared to head (3a6eb88) 61.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev     #220       +/-   ##
==========================================
+ Coverage   0.00%   61.31%   +61.31%     
==========================================
  Files         20       20               
  Lines        892      897        +5     
  Branches     229      227        -2     
==========================================
+ Hits           0      550      +550     
+ Misses       892      345      -547     
- Partials       0        2        +2     
Impacted Files Coverage Δ
contracts/ERC5727/ERC5727Expirable.sol 100.00% <ø> (+100.00%) ⬆️
contracts/ERC5727/ERC5727.sol 90.99% <90.90%> (+90.99%) ⬆️
contracts/ERC3525/ERC3525.sol 72.35% <100.00%> (+72.35%) ⬆️
contracts/ERC3525/ERC3525SlotEnumerable.sol 57.57% <100.00%> (+57.57%) ⬆️
contracts/ERC5727/ERC5727Claimable.sol 100.00% <100.00%> (+100.00%) ⬆️
contracts/ERC5727/ERC5727Delegate.sol 100.00% <100.00%> (+100.00%) ⬆️
contracts/ERC5727/ERC5727Governance.sol 98.63% <100.00%> (+98.63%) ⬆️
contracts/ERC5727/ERC5727Recovery.sol 100.00% <100.00%> (+100.00%) ⬆️
contracts/ERC721/ERC721Enumerable.sol 79.41% <100.00%> (+79.41%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@beyond009 beyond009 changed the title feat: add uint test & fix bugs feat: add unit test & fix bugs Apr 11, 2023
Copy link
Member

@AustinZhu AustinZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinZhu
Copy link
Member

@beyond009 Lockfile is outdated. Can you update it?

@github-actions
Copy link

Slither Analyzer Summary

Compiled with Builder
Number of lines: 4158 (+ 3801 in dependencies, + 0 in tests)
Number of assembly lines: 0
Number of contracts: 43 (+ 34 in dependencies, + 0 tests)

Number of optimization issues: 0
Number of informational issues: 107
Number of low issues: 11
Number of medium issues: 26
Number of high issues: 0

Use: Openzeppelin-Ownable
ERCs: ERC165, ERC721

@AustinZhu AustinZhu merged commit 85ed7af into dev Apr 11, 2023
@AustinZhu AustinZhu deleted the feature/fixbug branch April 11, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants