docs: add chain link test cases update guide #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadamu
commented
Aug 10, 2022
docs/core/chain_link.md
Outdated
| } | ||
| ``` | ||
|
|
||
| #### 2. Execute the latest desmos cli with the command `desmos create-link-json` with `tx.json` to create chain link proof data `data.json`. |
There was a problem hiding this comment.
I am thinking that building a testutil command for it would be helpful, say:
desmos testutil profiles show-chain-link-signature data.jsonWhat do you think? @RiccardoM @bragaz
There was a problem hiding this comment.
Do you mean a command to create both the data and the signature in one shot?
There was a problem hiding this comment.
Nope, I mean the command to show chain link signature in hex encode from proof data.json for updating chain link test case.
There was a problem hiding this comment.
Oh gotcha! Yeah I think it can be useful. @RiccardoM thoughts?
leobragaz
reviewed
Aug 17, 2022
docs/core/chain_link.md
Outdated
| } | ||
| ``` | ||
|
|
||
| #### 2. Execute the latest desmos cli with the command `desmos create-link-json` with `tx.json` to create chain link proof data `data.json`. |
There was a problem hiding this comment.
Do you mean a command to create both the data and the signature in one shot?
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
…chain-link-test-upgradation-guide
…om:desmos-labs/desmos into paul/add-chain-link-test-upgradation-guide
RiccardoM
changed the title
RiccardoM
changed the title
RiccardoM
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates the guide on how to properly update multi-signature account chain link tests after the Proto version of profiles change.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change