Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add x/relationships spec #837

Merged
merged 3 commits into from
May 16, 2022
Merged

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Apr 22, 2022

Description

This PR adds the spec folder inside the x/relationships module, containing the whole specification.

Depends-On: #829
Depends-On: #838


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM requested review from dadamu and leobragaz April 22, 2022 10:50
@RiccardoM RiccardoM added the docs/new Add a new documentation page, subsection of a page, or multimedia item label Apr 27, 2022
RiccardoM and others added 2 commits May 6, 2022 08:23
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@RiccardoM RiccardoM requested a review from leobragaz May 6, 2022 06:23
@RiccardoM RiccardoM merged commit ce5e1d1 into master May 16, 2022
@RiccardoM RiccardoM deleted the riccardo/relationships-spec branch May 16, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/new Add a new documentation page, subsection of a page, or multimedia item x/relationships
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants