Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): upgrade to Cosmos v0.44.0 #595

Merged
merged 20 commits into from
Sep 14, 2021
Merged

build(deps): upgrade to Cosmos v0.44.0 #595

merged 20 commits into from
Sep 14, 2021

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Aug 26, 2021 •
edited
Loading

Description

This PR upgrades Desmos to use Cosmos v0.44.0.
Some tests might need some fixes.

Closes #585

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@RiccardoM
Started the migrations towards Cosmos v0.43.0
afbf435 
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM
Completed the transition towards Cosmos v0.43.0
7e25f2b 
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM
Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…
852c07b 
…cosmos-v0.43-upgrade

� Conflicts:
�	go.mod
�	go.sum
@RiccardoM RiccardoM changed the title Cosmos v0.43.0 upgrade feat: upgrade to Cosmos v0.43.0 Aug 26, 2021
@RiccardoM RiccardoM changed the title feat: upgrade to Cosmos v0.43.0 deps: upgrade to Cosmos v0.43.0 Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 27, 2021 •
edited
Loading

Codecov Report

Merging #595 (8fc152e) into master (16e1eeb) will increase coverage by 9.25%.
The diff coverage is 78.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
+ Coverage   75.59%   84.84%   +9.25%     
==========================================
  Files          94       91       -3     
  Lines        4519     5392     +873     
==========================================
+ Hits         3416     4575    +1159     
+ Misses        960      606     -354     
- Partials      143      211      +68
Impacted Files Coverage Δ
app/genesis.go 100.00% <ø> (ø)
x/commons/commons.go 100.00% <ø> (ø)
x/profiles/keeper/keeper_chain_links.go 87.50% <ø> (ø)
x/profiles/keeper/keeper_dtag_transfers.go 91.30% <ø> (-3.30%) ⬇️
x/profiles/keeper/keeper_relationships.go 71.42% <ø> (-28.58%) ⬇️
x/profiles/keeper/msg_server_app_link.go 0.00% <ø> (ø)
x/profiles/keeper/msg_server_blocks.go 100.00% <ø> (ø)
x/profiles/keeper/msg_server_chain_link.go 100.00% <ø> (ø)
x/profiles/keeper/msg_server_dtag_transfers.go 74.75% <ø> (-1.72%) ⬇️
x/profiles/keeper/msg_server_relationships.go 100.00% <ø> (ø)
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e25c07b...8fc152e. Read the comment docs.

@dadamu dadamu force-pushed the riccardo/cosmos-v0.43-upgrade branch from 5e439fa to 1936e81 Compare August 30, 2021 08:29
@RiccardoM
Updated Cosmos to v0.44.0
9517f91 
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM changed the title deps: upgrade to Cosmos v0.43.0 deps: upgrade to Cosmos v0.44.0 Sep 6, 2021
RiccardoM
RiccardoM commented Sep 7, 2021
View reviewed changes
third_party/proto/cosmos/base/query/v1beta1/pagination.proto
@@ -30,6 +30,9 @@ message PageRequest {
// count_total is only respected when offset is used. It is ignored when key
// is set.
bool count_total = 4;

// reverse is set to true if results are to be returned in the descending order.
bool reverse = 5;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see this was added. Nice!

@RiccardoM
Reverted default server config gas price
2c0ecaa 
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM
Copy link
Contributor Author

I would like to ask both of you @bragaz @dadamu to approve this PR (I can't since I'm the one that made it) to make sure we all agree on the changed before merging it. Please do this after a detailed review

@RiccardoM
Updated changeset and added changelog entry
88b5f46 
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM
Updated changeset entries
f2c974d 
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM
Added the deps type of change
82c8c25 
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM force-pushed the riccardo/cosmos-v0.43-upgrade branch from c2dae22 to 82c8c25 Compare September 8, 2021 08:28
dadamu
dadamu reviewed Sep 8, 2021
View reviewed changes
leobragaz
leobragaz reviewed Sep 8, 2021
View reviewed changes
RiccardoM and others added 2 commits September 9, 2021 11:10
@RiccardoM @leobragaz
Update .changeset/config.yaml
65d2bcc 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@RiccardoM
Updated Proto versions
a115898 
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
leobragaz
leobragaz approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready, I think we can merge this.

dadamu
dadamu reviewed Sep 9, 2021
View reviewed changes
@dadamu dadamu self-requested a review September 9, 2021 17:48
dadamu
dadamu approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@dadamu dadamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks ready to be merged.

@RiccardoM RiccardoM changed the title deps: upgrade to Cosmos v0.44.0 build(deps): upgrade to Cosmos v0.44.0 Sep 13, 2021
@RiccardoM
Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…
d9105af 
…cosmos-v0.43-upgrade

� Conflicts:
�	go.mod
�	go.sum
@github-actions github-actions bot added kind/build Related to the build of the project kind/ci Improve the CI/CD x/CLI x/profiles Module that allows to create and manage decentralized social profiles labels Sep 13, 2021
@RiccardoM
Reverted tm-db upgrade
8fc152e 
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM merged commit df0deb7 into master Sep 14, 2021
@RiccardoM RiccardoM deleted the riccardo/cosmos-v0.43-upgrade branch September 14, 2021 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dadamu dadamu dadamu approved these changes

@leobragaz leobragaz leobragaz approved these changes

Assignees
No one assigned
Labels
kind/build Related to the build of the project kind/ci Improve the CI/CD x/CLI x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Cosmos v0.43
3 participants
@RiccardoM @dadamu @leobragaz