Application links tests #484

RiccardoM · 2021-06-14T10:15:35Z

Description

This PR introduces tests for the new application links feature.
Works towards #472

Checklist

Targeted PR against correct branch.
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Wrote unit tests.
Wrote integration tests (simulation & CLI).
Updated the documentation.
Added an entry to the CHANGELOG.md file.
Re-reviewed Files changed in the Github PR explorer.

See PR #473

…app-links

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

…iccardo/app-links-logic

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

…mos into riccardo/app-links-tests � Conflicts: � x/profiles/types/models_app_links.go

…app-links

codecov · 2021-06-14T10:20:03Z

Codecov Report

Merging #484 (0eab15f) into master (2921d21) will decrease coverage by 0.56%.
The diff coverage is 71.81%.

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
- Coverage   84.21%   83.64%   -0.57%     
==========================================
  Files          87       90       +3     
  Lines        3933     4372     +439     
==========================================
+ Hits         3312     3657     +345     
- Misses        478      556      +78     
- Partials      143      159      +16

Impacted Files	Coverage Δ
x/profiles/keeper/keeper_chain_links.go	`90.90% <ø> (ø)`
x/profiles/keeper/msg_server_app_link.go	`0.00% <0.00%> (ø)`
x/profiles/keeper/msgs_server_profile.go	`76.74% <ø> (ø)`
x/profiles/types/msgs_chain_links.go	`86.95% <ø> (ø)`
x/profiles/types/query_app_links.go	`0.00% <0.00%> (ø)`
x/profiles/client/cli/cli_app_links.go	`30.76% <30.76%> (ø)`
x/profiles/keeper/grpc_query.go	`74.32% <71.42%> (-0.68%)`	⬇️
x/profiles/keeper/keeper_app_links.go	`80.00% <80.00%> (ø)`
x/profiles/types/msgs_app_links.go	`86.27% <86.27%> (ø)`
x/profiles/keeper/relay_app_links.go	`95.12% <95.12%> (ø)`
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2921d21...0eab15f. Read the comment docs.

Co-authored-by: Paul <p22626262@gmail.com>

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

…iccardo/app-links-logic

…mos into riccardo/app-links-tests � Conflicts: � x/profiles/types/msgs_app_links.go

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

…mos into riccardo/app-links-tests

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

See PR #479

…to riccardo/app-links-tests � Conflicts: � x/profiles/client/cli/cli_app_links.go � x/profiles/keeper/keeper_app_links.go � x/profiles/keeper/relay_app_links_test.go � x/profiles/module_ibc.go � x/profiles/types/genesis_test.go � x/profiles/types/models_app_links.go � x/profiles/types/msgs_app_links.go

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

…les directly Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

leobragaz · 2021-06-16T12:42:41Z

x/profiles/client/cli/cli_app_links_test.go

+	"github.com/desmos-labs/desmos/x/profiles/client/cli"
+	"github.com/desmos-labs/desmos/x/profiles/types"
+)
+


The GetCmdLinkApplication tests are missing here 👀

Yeah I know, unfortunately this is not an easy method to test. What we would have to do is:

Instantiate a fake Band chain

Create an IBC connection between the Desmos and Band chain

Use that fake connection to send the packet using this command

Since this is very complicated, I think it's better to leave as it is without any test right now. I will take care of opening an issue and explaining what should be done once the PR gets merged

Oh ok no problem!

…app-links � Conflicts: � proto/desmos/profiles/v1beta1/genesis.proto � x/profiles/client/cli/cli_chain_links.go � x/profiles/client/cli/query.go � x/profiles/keeper/alias_functions.go � x/profiles/keeper/genesis.go � x/profiles/keeper/genesis_test.go � x/profiles/keeper/keeper.go � x/profiles/types/genesis.go � x/profiles/types/genesis.pb.go � x/profiles/types/genesis_test.go � x/profiles/types/keys.go � x/profiles/types/query.pb.go � x/profiles/types/query.pb.gw.go

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

…to riccardo/app-links-tests � Conflicts: � proto/desmos/profiles/v1beta1/genesis.proto � x/profiles/client/cli/query.go � x/profiles/keeper/genesis.go � x/profiles/keeper/genesis_test.go � x/profiles/keeper/grpc_query_test.go � x/profiles/keeper/keeper_chain_links_test.go � x/profiles/keeper/msg_server_chain_link_test.go � x/profiles/types/genesis.go � x/profiles/types/genesis.pb.go � x/profiles/types/genesis_test.go � x/profiles/types/keys.go

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

…app-links-tests � Conflicts: � x/profiles/keeper/querier_test.go

RiccardoM · 2021-06-21T06:10:49Z

@bragaz Can I merge this? What do you think?

leobragaz · 2021-06-21T06:45:52Z

@RiccardoM Yes it's good! Go ahead 👍

RiccardoM and others added 13 commits June 10, 2021 19:35

Added app links Proto files

c2c229d

See PR #473

Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…

ccdc209

…app-links

Generated Proto files definitions

c8f570d

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Added the logic for the application links

98915f8

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Fixed tests and started adding more

f2dbd1f

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Update x/profiles/client/cli/cli_app_links.go

920f4c3

Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>

Update x/profiles/keeper/msg_server_app_link.go

673802d

Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>

Added more tests

8649213

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Added missing doc

c8eaf15

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Merge remote-tracking branch 'origin/riccardo/app-links-logic' into r…

3367be4

…iccardo/app-links-logic

Added missing genesis application links state

193618c

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Merge branch 'riccardo/app-links-logic' of github.com:desmos-labs/des…

c021b67

…mos into riccardo/app-links-tests � Conflicts: � x/profiles/types/models_app_links.go

Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…

0ae6ff7

…app-links

RiccardoM and others added 16 commits June 15, 2021 07:09

Update x/profiles/module_ibc.go

39ef876

Co-authored-by: Paul <p22626262@gmail.com>

Fixed suggestions

318e514

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Merge remote-tracking branch 'origin/riccardo/app-links-logic' into r…

9c8518a

…iccardo/app-links-logic

Merge branch 'riccardo/app-links-logic' of github.com:desmos-labs/des…

e5bec20

…mos into riccardo/app-links-tests � Conflicts: � x/profiles/types/msgs_app_links.go

Fixed keys values

fb96b83

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Merge branch 'riccardo/app-links-logic' of github.com:desmos-labs/des…

d890aa7

…mos into riccardo/app-links-tests

Added more tests

e5b3844

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Added missing gRPC query test

fe4d07d

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Implemented application links logic

e94b29b

See PR #479

Fixed CLI commands

deda911

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Added DONTCOVER inside query.go and tx.go

d35aa5c

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Added alias_functions tests

e07f7aa

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Added genesis tests

a57fd1d

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Added DONTCOVER to migrations

75c124f

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Added some tests for the relay_app_links file

9605359

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

RiccardoM added 11 commits June 15, 2021 13:03

Fixed tests

9994c1d

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Removed external dependency to Band Protocol and included required fi…

a3d15e3

…les directly Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Fixed lint errors

e59cb7e

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Fixed tests

6b9937c

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Added DONTCOVER to keeper_ibc

9ffc5d9

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Added some tests to relay_app_links

34939a1

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Changed the structure of ApplicationLink

fe248ed

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Added test for OnOracleRequestAcknowledgementPacket

acdb771

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Added tests for StartProfileConnection

374de54

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Added CLI tests

256c2c9

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Fixed tests

c269219

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

RiccardoM requested review from dadamu and leobragaz and removed request for dadamu June 16, 2021 11:04

RiccardoM marked this pull request as ready for review June 16, 2021 11:04

leobragaz reviewed Jun 16, 2021

View reviewed changes

RiccardoM added 5 commits June 18, 2021 08:57

Merged master

2e38a67

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Fixed conflicts

c96d821

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…

0eab15f

…app-links-tests � Conflicts: � x/profiles/keeper/querier_test.go

RiccardoM requested a review from leobragaz June 21, 2021 06:10

RiccardoM enabled auto-merge (squash) June 21, 2021 06:48

leobragaz approved these changes Jun 21, 2021

View reviewed changes

RiccardoM merged commit 3aba36d into master Jun 21, 2021

RiccardoM deleted the riccardo/app-links-tests branch June 21, 2021 07:05

RiccardoM mentioned this pull request Jun 21, 2021

Verify profile with external applications #502

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Application links tests #484

Application links tests #484

RiccardoM commented Jun 14, 2021

codecov bot commented Jun 14, 2021 •

edited

Loading

leobragaz Jun 16, 2021

RiccardoM Jun 18, 2021

leobragaz Jun 18, 2021

RiccardoM commented Jun 21, 2021

leobragaz commented Jun 21, 2021

Application links tests #484

Application links tests #484

Conversation

RiccardoM commented Jun 14, 2021

Description

Checklist

codecov bot commented Jun 14, 2021 • edited Loading

Codecov Report

leobragaz Jun 16, 2021

Choose a reason for hiding this comment

RiccardoM Jun 18, 2021

Choose a reason for hiding this comment

leobragaz Jun 18, 2021

Choose a reason for hiding this comment

RiccardoM commented Jun 21, 2021

leobragaz commented Jun 21, 2021

codecov bot commented Jun 14, 2021 •

edited

Loading