Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register missing stargate queries for contract #1218

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Aug 24, 2023

Description

Closes: #XXXX
This PR registers missing stargate queries for contract.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dadamu dadamu requested a review from a team as a code owner August 24, 2023 13:05
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ca48a5b) 80.49% compared to head (69c3911) 80.49%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1218   +/-   ##
=======================================
  Coverage   80.49%   80.49%           
=======================================
  Files         218      218           
  Lines       18287    18292    +5     
=======================================
+ Hits        14720    14725    +5     
  Misses       2955     2955           
  Partials      612      612           
Files Changed Coverage Δ
app/wasm_config.go 98.01% <100.00%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiccardoM RiccardoM merged commit e1e53c5 into master Aug 24, 2023
@RiccardoM RiccardoM deleted the paul/register-missing-wasm-stargate-querier branch August 24, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants