Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the post creation CLI command #121

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Update the post creation CLI command #121

merged 3 commits into from
Mar 26, 2020

Conversation

leobragaz
Copy link
Contributor

@leobragaz leobragaz commented Mar 24, 2020 •
edited
Loading

Description

Updating the CLI create post's command to better fit the latest edits. Now the message field is optional and the allow-comments one become a flag.
Closes #117

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@leobragaz leobragaz added kind/enhancement Enhance an already existing feature; no "New feature" to add x/posts Post module Status:WIP labels Mar 24, 2020
@leobragaz leobragaz self-assigned this Mar 24, 2020
@leobragaz leobragaz requested a review from RiccardoM March 24, 2020 19:27
@leobragaz leobragaz added this to the v0.4.0 milestone Mar 25, 2020
RiccardoM
RiccardoM suggested changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, some small changes and then it's good to be merged! 💯

RiccardoM
RiccardoM approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 💯

@RiccardoM RiccardoM merged commit 8ec4a1b into master Mar 26, 2020
@RiccardoM RiccardoM deleted the leonardo/updating-post-creation-cli-cmd branch March 30, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoM RiccardoM RiccardoM approved these changes

Assignees

@leobragaz leobragaz

Labels
kind/enhancement Enhance an already existing feature; no "New feature" to add x/posts Post module
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Update the post creation CLI command
2 participants
@leobragaz @RiccardoM