Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/cosmwasm/wasmd to v0.40.0-rc.1 #1133

Merged
merged 4 commits into from
May 4, 2023

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented May 3, 2023

Description

This PR bumps github.com/CosmWasm/wasmd to v0.40.0-rc.1


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@RiccardoM RiccardoM requested a review from a team as a code owner May 3, 2023 19:29
@RiccardoM RiccardoM requested review from manu0466 and dadamu May 3, 2023 19:29
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label May 3, 2023
@@ -238,14 +238,13 @@ var (
mint.AppModuleBasic{},
distr.AppModuleBasic{},
gov.NewAppModuleBasic(
append(
wasmclient.ProposalHandlers,
[]govclient.ProposalHandler{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new CosmWasm has been updated to adapt to Cosmos SDK v0.47.x and use v1 version of the gov module. See here

@RiccardoM RiccardoM mentioned this pull request May 3, 2023
19 tasks
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fe660b9) 80.93% compared to head (ac1483f) 80.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1133   +/-   ##
=======================================
  Coverage   80.93%   80.93%           
=======================================
  Files         198      198           
  Lines       16966    16966           
=======================================
  Hits        13731    13731           
  Misses       2638     2638           
  Partials      597      597           
Impacted Files Coverage Δ
app/app.go 87.60% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@dadamu dadamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just have a minor fix of entry file
Ready to go after it is modified

…95d2ab54ed3923b819b8e.yaml

Co-authored-by: Paul Chen <p22626262@gmail.com>
@RiccardoM RiccardoM changed the title build(deps): bump github.com/CosmWasm/wasmd to v0.40.0-rc.1 build(deps): bump github.com/cosmwasm/wasmd to v0.40.0-rc.1 May 4, 2023
@RiccardoM RiccardoM merged commit 7f24f21 into master May 4, 2023
@RiccardoM RiccardoM deleted the riccardom/bump-cosmwasm branch May 4, 2023 13:31
mergify bot pushed a commit that referenced this pull request May 16, 2023
## Description

This PR prepares the Desmos Core codebase for the `v5.0.0` release.

To do this, the following changes have been made: 

1. bump the Go package name to `github.com/desmos-labs/desmos/v5`
2. update the on-chain upgrade workflow to test the `v5.0.0` upgrade handler
3. updated the `CHANGELOG.md` file with the new changes 
4. deleted all the changeset entries

Depends-On: #1132
Depends-On: #1133

[DCD-348](https://forbole.atlassian.net/browse/DCD-348)

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html)
- [ ] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

[DCD-348]: https://forbole.atlassian.net/browse/DCD-348?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants