Switch to more standardish/expected callback(error, data) pattern

[bryanburgers]

It would be nice if the library used the standard callback pattern.

twit.get('/statuses/show.js', { id: id }, function(err, data) {
    if (err) {
        // ...
    }
    // do something with data
});

[sedge]

Please please please!

I was pulling my hair out trying to figure out why my callback logic wasn't executing, only to find out it only executes when there's an error.

@desmondmorris This wouldn't be hard to implement. Should I file a P/R?

[desmondmorris]

👍 Its def time for this. @sedge go for it! We should probably track these changes against a new branch, 1.x. We can work towards a better callback pattern, test coverage and code standards.

[sedge]

Will do. I was wrong about when the callback logic fires - user error 😦

[fuchse]

👍

[despairblue]

👍

[desmondmorris]

👍 I am starting to flesh a roadmap for a general cleanup of this library. This will be top of th is list https://github.com/desmondmorris/node-twitter/wiki/1.x-Roadmap

[desmondmorris]

@bryanburgers @sedge @fuchse @despairblue - A new callback pattern has been added to v1.x. Give it a spin.

See https://github.com/desmondmorris/node-twitter/blob/master/README.md for details