Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify and correct arch detection #529

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Conversation

theofficialgman
Copy link
Contributor

'x32' is not a valid architecture in all released versions of node.js anymore. v8 dropped support for it in 2018

@theofficialgman
Copy link
Contributor Author

@tidy-dev can we get this merged? its just a little cleanup/fixup

@theofficialgman
Copy link
Contributor Author

@sergiou87 hey I noticed you never merged this. Sorry there was an issue in my original implementation. x86 is named incorrectly and this corrects it to ia32 which is the correct packaging standard. see the commit message

'x32' is not a valid architecture in all released versions of node.js anymore. v8 dropped support for it in 2018
@sergiou87 sergiou87 merged commit b0957f1 into desktop:main Jul 9, 2023
@sergiou87
Copy link
Member

Cool, no problem. I guess you need another release with these changes?

@theofficialgman
Copy link
Contributor Author

Cool, no problem. I guess you need another release with these changes?

Yeah if we wanted to build for x86 32bit we do. Can you just delete the current release and tag and just re-make it? Or just version bump again, I don't care how you do it.

@sergiou87
Copy link
Member

Probably better to do a new version so people don't get confused… let me handle that

@sergiou87 sergiou87 mentioned this pull request Jul 12, 2023
@theofficialgman
Copy link
Contributor Author

theofficialgman commented Jul 12, 2023

I forgot that critically electron has not supported x86 on linux in multiple years, lol https://www.electronjs.org/blog/linux-32bit-support

this still needed to be fixed though since other projects might want to use the x86 npm package. nodejs can still be built for x86 so there are potential consumers of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants