-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify and correct arch detection #529
Conversation
@tidy-dev can we get this merged? its just a little cleanup/fixup |
@sergiou87 hey I noticed you never merged this. Sorry there was an issue in my original implementation. |
'x32' is not a valid architecture in all released versions of node.js anymore. v8 dropped support for it in 2018
Cool, no problem. I guess you need another release with these changes? |
Yeah if we wanted to build for x86 32bit we do. Can you just delete the current release and tag and just re-make it? Or just version bump again, I don't care how you do it. |
Probably better to do a new version so people don't get confused… let me handle that |
I forgot that critically electron has not supported x86 on linux in multiple years, lol https://www.electronjs.org/blog/linux-32bit-support this still needed to be fixed though since other projects might want to use the x86 npm package. nodejs can still be built for x86 so there are potential consumers of this. |
'x32' is not a valid architecture in all released versions of node.js anymore. v8 dropped support for it in 2018