Don't rely on truthiness #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into this today while needing to shell out to a git command with an empty stdin (but I still needed there to be an open and subsequent close of stdin). The truthiness check for `options.stdin` fails for empty strings as yabbascript thinks that's equalish to false. This change makes it so that only when the user omits to pass a value for stdin do we skip closing stdin.
| @@ -224,7 +224,7 @@ export class GitProcess { | |||
| } | |||
| }) | |||
|
|
|||
| if (options && options.stdin) { | |||
| if (options && options.stdin !== undefined) { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
shiftkey
approved these changes
Jan 28, 2018
|
Nice find @niik. I've published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this today while needing to shell out to a git command with an empty stdin (but I still needed there to be an open and subsequent close of stdin).
The truthiness check for
options.stdinfails for empty strings as yabbascript thinks that's equalish to false. This change makes it so that only when the user omits to pass a value for stdin do we skip closing stdin.