Added support for setting the caret and the selection layer #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VPKSoft
suggested changes
Oct 31, 2022
Shared/Layer.cs
Outdated
| namespace ScintillaNET; | ||
|
|
||
| /// <summary> | ||
| /// |
There was a problem hiding this comment.
Perhaps this missing summary could be added. I can add it too after work, otherwise looks great.👍
|
Oh no worries, I just added it myself. 🙂 |
VPKSoft
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Layer enum that groups
SC_LAYER_BASE,SC_LAYER_UNDER_TEXTandSC_LAYER_OVER_TEXT. Added propertiesSelectionLayerandCaretLineLayerin Scintilla control to set the layer of the text selection and the layer of the currently highlighted line whenCaretLineVisibleis set.Note: one thing that I couldn't get around is the default value of
CaretLineLayerproperty. While for a newly created control it reportsBaseor0, the behavior is as ifOverText(or2) is selected. This might create confusion but I'm not sure if there is anything to be done as, if there is a bug, that seems to be in the native control side. Perhaps addingCaretLineLayer = Layer.Basein the constructor might be enough?Fixes #24