Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing FFT issue with odd signals. Making state default to None in instantiate. #50

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

pseeth
Copy link
Contributor

@pseeth pseeth commented Aug 23, 2022

Fixes an issue @ritheshkumar95 was having when using RIR transform with odd length signals. Also makes the state argument to transform.instantiate optional. By default it'll use None which is whatever the numpy random state is at that time.

@pseeth pseeth requested a review from ritheshkumar95 August 23, 2022 23:31
Copy link

@ritheshkumar95 ritheshkumar95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch @pseeth . Looks like the fixes were simple enough but super great that you did it so fast.

Also curious about another thing. Do you envision audiotools as a majorly pytorch-based library? (rather than numpy)

If so, it would be very convenient if random states are all defaulted to pytorch rng rather than numpy. This way, we don't need to worry about DDP headaches and everything will work magically without much thought.

@pseeth pseeth merged commit 4f07af6 into master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants