Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added functions to correct for extinction and v6 cuts #15

Merged
merged 20 commits into from
May 1, 2024
Merged

Conversation

myamamoto26
Copy link
Contributor

  • Added functions to compute dereddened magnitudes.
  • Added a function to add and change columns and save in a new file.
  • Added V6 cuts (new i-band mag 24.5 cut, size cut, updated pgauss cut etc.) and new mask locations.

@myamamoto26
Copy link
Contributor Author

To-Do: adjust i-band magnitude cut.

@myamamoto26 myamamoto26 marked this pull request as ready for review December 5, 2023 16:20
Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to double check a few items and write a few tests before we merge.

  • figure out new i-band cut (from @myamamoto26's comment)
  • write tests of new helper functions to compute asinh flux from mag etc.
  • double check the asinh mag stuff is ok to use with the reddening stuff with Eli

des_y6utils/mdet.py Outdated Show resolved Hide resolved
des_y6utils/mdet.py Outdated Show resolved Hide resolved
@beckermr
Copy link
Collaborator

beckermr commented Dec 6, 2023

I chatted with Eli and we need to apply the dereddening to the fluxes directly, not the lupton mags.

des_y6utils/mdet.py Outdated Show resolved Hide resolved
des_y6utils/mdet.py Outdated Show resolved Hide resolved
des_y6utils/mdet.py Outdated Show resolved Hide resolved
des_y6utils/mdet.py Outdated Show resolved Hide resolved
des_y6utils/mdet.py Outdated Show resolved Hide resolved
des_y6utils/mdet.py Outdated Show resolved Hide resolved
des_y6utils/mdet.py Outdated Show resolved Hide resolved
@beckermr beckermr merged commit 96f87f5 into main May 1, 2024
1 check passed
@beckermr beckermr deleted the v6cuts branch May 1, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants