Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #62 #79

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Fix for issue #62 #79

merged 1 commit into from
Oct 3, 2017

Conversation

alexarana
Copy link

Support DynamoDBMapper v2 annotations (@DynamoDBTypeConverted, @DynamoDBTyped etc.) instead of/in addition to @DynamoDBMarshalling for query methods.

I have left a few TODOs in the code to highlight areas where feedback is particularly sought.

…namoDBTypeConverted, @DynamoDBTyped etc.) instead of/in addition to @DynamoDBMarshalling for query methods.

Signed-off-by: Alex Arana <alex.arana@skyhubdigital.com>
@codecov-io
Copy link

Codecov Report

Merging #79 into master will decrease coverage by 0.13%.
The diff coverage is 51.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
- Coverage     40.58%   40.44%   -0.14%     
  Complexity      336      336              
============================================
  Files            64       64              
  Lines          1752     1763      +11     
  Branches        341      346       +5     
============================================
+ Hits            711      713       +2     
- Misses          936      942       +6     
- Partials        105      108       +3
Impacted Files Coverage Δ Complexity Δ
...in/spring/data/dynamodb/core/DynamoDBTemplate.java 27.95% <0%> (-0.31%) 10 <0> (ø)
...ery/DynamoDBEntityWithHashAndRangeKeyCriteria.java 74.11% <100%> (ø) 74 <1> (ø) ⬇️
...repository/query/AbstractDynamoDBQueryCreator.java 46.8% <100%> (+1.15%) 11 <2> (ø) ⬇️
...y/query/DynamoDBEntityWithHashKeyOnlyCriteria.java 78.37% <100%> (ø) 14 <1> (ø) ⬇️
...epository/query/AbstractDynamoDBQueryCriteria.java 68.38% <47.82%> (-1.72%) 101 <3> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deef49a...4e4d105. Read the comment docs.

@fpoolev
Copy link

fpoolev commented Apr 4, 2017

+1 This would be helpful for my project too.

@derjust
Copy link
Owner

derjust commented Oct 3, 2017

Excellent. Thank you!

@derjust derjust merged commit 23348bd into derjust:master Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants