Akmal / feat: add radio button & radio group components #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying quill-ui with
|
| Latest commit: |
3b1d969
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://78d6470f.quill-ui.pages.dev |
| Branch Preview URL: | https://f-add-radio-button-component.quill-ui.pages.dev |
henry-deriv
reviewed
Apr 8, 2024
henry-deriv
reviewed
Apr 8, 2024
lib/components/SelectionControl/radio/radio-button/radio-button.scss
Outdated
Show resolved
Hide resolved
henry-deriv
reviewed
Apr 8, 2024
henry-deriv
reviewed
Apr 8, 2024
lib/components/SelectionControl/radio/radio-group/radio-group.stories.tsx
Outdated
Show resolved
Hide resolved
henry-deriv
reviewed
Apr 8, 2024
henry-deriv
reviewed
Apr 8, 2024
lib/components/SelectionControl/radio/radio-button/radio-button.scss
Outdated
Show resolved
Hide resolved
kate-deriv
reviewed
Apr 8, 2024
kate-deriv
reviewed
Apr 8, 2024
kate-deriv
reviewed
Apr 8, 2024
maryia-deriv
requested changes
Apr 8, 2024
lib/components/SelectionControl/radio/radio-button/radio-button.stories.tsx
Outdated
Show resolved
Hide resolved
kate-deriv
reviewed
Apr 8, 2024
kate-deriv
reviewed
Apr 8, 2024
kate-deriv
reviewed
Apr 8, 2024
kate-deriv
reviewed
Apr 8, 2024
lib/components/SelectionControl/radio/radio-button/radio-button.stories.tsx
Outdated
Show resolved
Hide resolved
kate-deriv
reviewed
Apr 8, 2024
lib/components/SelectionControl/radio/radio-group/__tests__/radio-group.test.tsx
Show resolved
Hide resolved
kate-deriv
reviewed
Apr 8, 2024
kate-deriv
reviewed
Apr 9, 2024
kate-deriv
reviewed
Apr 9, 2024
maryia-deriv
reviewed
Apr 9, 2024
lib/components/SelectionControl/radio/radio-group/radio-group.stories.tsx
Show resolved
Hide resolved
kate-deriv
reviewed
Apr 9, 2024
maryia-deriv
requested changes
Apr 9, 2024
lib/components/SelectionControl/radio/radio-button/radio-button.scss
Outdated
Show resolved
Hide resolved
kate-deriv
reviewed
Apr 9, 2024
kate-deriv
reviewed
Apr 9, 2024
kate-deriv
reviewed
Apr 9, 2024
kate-deriv
reviewed
Apr 9, 2024
lib/components/SelectionControl/radio/radio-button/radio-button.stories.tsx
Show resolved
Hide resolved
kate-deriv
reviewed
Apr 11, 2024
jia-deriv
approved these changes
Apr 15, 2024
henry-deriv
approved these changes
Apr 15, 2024
prince-deriv
approved these changes
Apr 15, 2024
| <StandaloneCircleDotBoldIcon | ||
| data-testid={`dt_checked_icon_${value}_${disabled}`} | ||
| fill={disabled ? "#b8b8b8" : "#000000"} | ||
| iconSize={size} |
There was a problem hiding this comment.
Why this icon doesn't have the tabIndex and the other one has?
There was a problem hiding this comment.
I want to avoid selecting the selected option. Since there's no point to click the option which is already selected, I only added tabIndex to the icon which is used for non-selected options.
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature introduces the implementation of radio button and radio group components to enhance user interface options within the project. Radio buttons provide users with a selection mechanism for exclusive choices within a group, while radio groups manage the collective behavior of multiple radio buttons.
Radio Button Component: The radio button component is created to allow users to select a single option from a set of mutually exclusive choices. Each radio button represents a distinct choice, and only one option can be selected at a time.
Radio Group Component: The radio group component encapsulates multiple radio buttons that belong to the same group. It ensures that only one radio button within the group can be selected at any given time, enforcing the mutual exclusivity of choices.
These components offer a user-friendly and intuitive way for users to make selections within forms, surveys, or any other interactive elements where exclusive choices are required. By adding radio button and radio group components, the project enhances its usability and provides a consistent and familiar interface for users to interact with.