Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor darkmode fixes #445

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix: minor darkmode fixes #445

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26bcd0b
fix: minor darkmode fixes
henry-deriv Sep 19, 2024
b0e2510
fix: fuck this snapshot
henry-deriv Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/components/Input/search-field/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const SearchField = forwardRef<HTMLInputElement, SearchFieldProps>(
}}
>
<StandaloneCircleXmarkFillIcon
fill="var(--component-textIcon-normal-default)"
fill="var(--component-textIcon-normal-subtle)"
iconSize="sm"
/>
</button>
Expand Down
16 changes: 8 additions & 8 deletions ...ts/SelectionControl/radio/radio-button/__tests__/__snapshots__/radio-button.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ exports[`RadioButton component should be checked by default if defaultChecked is
>
<svg
data-testid="dt_checked_icon_option1_false"
fill="#000000"
fill="var(--component-textIcon-normal-prominent)"
height="32"
role="img"
viewBox="0 0 32 32"
Expand Down Expand Up @@ -59,7 +59,7 @@ exports[`RadioButton component should be disabled if disabled is true 1`] = `
>
<svg
data-testid="dt_unchecked_icon_option3_true"
fill="#b8b8b8"
fill="var(--component-textIcon-normal-disabled)"
height="32"
role="img"
tabindex="0"
Expand Down Expand Up @@ -99,7 +99,7 @@ exports[`RadioButton component should not be checked by default if defaultChecke
>
<svg
data-testid="dt_unchecked_icon_option2_false"
fill="#7e7e7e"
fill="var(--component-textIcon-normal-subtle)"
height="32"
role="img"
tabindex="0"
Expand Down Expand Up @@ -137,7 +137,7 @@ exports[`RadioButton component should not render info icon when hasInfo is false
>
<svg
data-testid="dt_unchecked_icon_undefined_false"
fill="#7e7e7e"
fill="var(--component-textIcon-normal-subtle)"
height="32"
role="img"
tabindex="0"
Expand Down Expand Up @@ -178,7 +178,7 @@ exports[`RadioButton component should not trigger click event on input when info
>
<svg
data-testid="dt_unchecked_icon_option4_true"
fill="#b8b8b8"
fill="var(--component-textIcon-normal-disabled)"
height="32"
role="img"
tabindex="0"
Expand Down Expand Up @@ -216,7 +216,7 @@ exports[`RadioButton component should render correctly with default props 1`] =
>
<svg
data-testid="dt_unchecked_icon_undefined_false"
fill="#7e7e7e"
fill="var(--component-textIcon-normal-subtle)"
height="32"
role="img"
tabindex="0"
Expand Down Expand Up @@ -254,7 +254,7 @@ exports[`RadioButton component should render info icon when hasInfo is true 1`]
>
<svg
data-testid="dt_unchecked_icon_undefined_false"
fill="#7e7e7e"
fill="var(--component-textIcon-normal-subtle)"
height="32"
role="img"
tabindex="0"
Expand Down Expand Up @@ -316,7 +316,7 @@ exports[`RadioButton component should render with a custom className 1`] = `
>
<svg
data-testid="dt_unchecked_icon_undefined_false"
fill="#7e7e7e"
fill="var(--component-textIcon-normal-subtle)"
height="32"
role="img"
tabindex="0"
Expand Down
4 changes: 2 additions & 2 deletions lib/components/SelectionControl/radio/radio-button/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,15 @@ export const RadioButton = ({
return (
<StandaloneCircleDotFillIcon
data-testid={`dt_checked_icon_${value}_${disabled}`}
fill={disabled ? "#b8b8b8" : "#000000"}
fill={disabled ? "var(--component-textIcon-normal-disabled)" : "var(--component-textIcon-normal-prominent)"}
iconSize={size}
/>
);
} else {
return (
<StandaloneCircleRegularIcon
data-testid={`dt_unchecked_icon_${value}_${disabled}`}
fill={disabled ? "#b8b8b8" : "#7e7e7e"}
fill={disabled ? "var(--component-textIcon-normal-disabled)" : "var(--component-textIcon-normal-subtle)"}
iconSize={size}
tabIndex={0}
/>
Expand Down
18 changes: 9 additions & 9 deletions ...ents/SelectionControl/radio/radio-group/__tests__/__snapshots__/radio-group.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ exports[`RadioGroup component calls onToggle when a radio button is selected 1`]
>
<svg
data-testid="dt_unchecked_icon_option1_false"
fill="#7e7e7e"
fill="var(--component-textIcon-normal-subtle)"
height="32"
role="img"
tabindex="0"
Expand Down Expand Up @@ -54,7 +54,7 @@ exports[`RadioGroup component calls onToggle when a radio button is selected 1`]
>
<svg
data-testid="dt_unchecked_icon_option2_false"
fill="#7e7e7e"
fill="var(--component-textIcon-normal-subtle)"
height="32"
role="img"
tabindex="0"
Expand Down Expand Up @@ -89,7 +89,7 @@ exports[`RadioGroup component calls onToggle when a radio button is selected 1`]
>
<svg
data-testid="dt_checked_icon_option3_false"
fill="#000000"
fill="var(--component-textIcon-normal-prominent)"
height="32"
role="img"
viewBox="0 0 32 32"
Expand Down Expand Up @@ -132,7 +132,7 @@ exports[`RadioGroup component renders radio buttons with correct labels 1`] = `
>
<svg
data-testid="dt_checked_icon_option1_false"
fill="#000000"
fill="var(--component-textIcon-normal-prominent)"
height="32"
role="img"
viewBox="0 0 32 32"
Expand Down Expand Up @@ -165,7 +165,7 @@ exports[`RadioGroup component renders radio buttons with correct labels 1`] = `
>
<svg
data-testid="dt_unchecked_icon_option2_false"
fill="#7e7e7e"
fill="var(--component-textIcon-normal-subtle)"
height="32"
role="img"
tabindex="0"
Expand Down Expand Up @@ -199,7 +199,7 @@ exports[`RadioGroup component renders radio buttons with correct labels 1`] = `
>
<svg
data-testid="dt_unchecked_icon_option3_false"
fill="#7e7e7e"
fill="var(--component-textIcon-normal-subtle)"
height="32"
role="img"
tabindex="0"
Expand Down Expand Up @@ -243,7 +243,7 @@ exports[`RadioGroup component should not call onToggle when a disabled radio but
>
<svg
data-testid="dt_checked_icon_option1_false"
fill="#000000"
fill="var(--component-textIcon-normal-prominent)"
height="32"
role="img"
viewBox="0 0 32 32"
Expand Down Expand Up @@ -277,7 +277,7 @@ exports[`RadioGroup component should not call onToggle when a disabled radio but
>
<svg
data-testid="dt_unchecked_icon_option2_true"
fill="#b8b8b8"
fill="var(--component-textIcon-normal-disabled)"
height="32"
role="img"
tabindex="0"
Expand Down Expand Up @@ -311,7 +311,7 @@ exports[`RadioGroup component should not call onToggle when a disabled radio but
>
<svg
data-testid="dt_unchecked_icon_option3_false"
fill="#7e7e7e"
fill="var(--component-textIcon-normal-subtle)"
height="32"
role="img"
tabindex="0"
Expand Down
Loading