-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth and run steps #19
Conversation
65dfe45
to
55dac72
Compare
i will add some more thest to verify all the auth options |
554c519
to
d36e4b5
Compare
Hey @derekkraan, this should be ready now! I've added netrc/more auth handling to generation and parsing and refined the functionality to define which steps to run but i'm still not sure if we should implement that. What is your opinion? The only current benefit would be, that req would not try to read in the netrc file and raise if not found. Then you would need to skip the |
@kevinschweikert Is the In that case, I think it's fine to add it. If I am misunderstanding, then please let me know. Can you add @acalejos as a co-author to the relevant commits that he helped to author? GitHub has a guide on how to do that. |
And we should also record this in the changelog. |
@derekkraan thanks for the feedback. The use case is exactly how you described. The auth step would try to read in the netrc file and raises when it does not exists. We wouldn't need this to run, because we get the filepath from the Will clean up the commits and add the co-author...must have lost it in a rebase. Thanks for the hint! |
0941b71
to
572a4f6
Compare
Co-authored-by: Andres Alejos <andres.c.alejos.mil@army.mil>
Co-authored-by: Andres Alejos <andres.c.alejos.mil@army.mil>
572a4f6
to
df6b07e
Compare
Co-authored-by: Andres Alejos <andres.c.alejos.mil@army.mil>
70b6002
to
2c37032
Compare
@derekkraan this should be ready now! |
Supersedes #14
This builds upon #14 to add more auto options and at the same time some finetuning options which req steps are run before generating the curl command