Adding some color to the events #243
Conversation
There was a problem hiding this comment.
Let me know your thoughts on my comments. I think it's a good feature, but want to avoid making things more confusing.
Some other options (besides my comments):
- Just specify one color as its own setting that would apply to all synced calendars (but wouldn't give you the "per calendar" customization)
- In
colorIds.gsthe user could specify the "icsUrl-to-color" mapping there which would in effect make this an advanced feature (so its not confusing in Code.gs and we can direct them there if they ask about it). I think I like this option the most. Maybe an advancedSettings.gs or something
|
Is it simplified enough for you @derekantrican and @jonas0b1011001? I really didn't want to go the unique-color-per-instance way as at least for myself, I need to know which event comes from what calendar. Let me know if you think I need to dig deeper on abstracting the code even more. From my point of view, it is simple enough to get the point without compromising functionality, but it is your call of course 😄 |
Code.gs
Outdated
| ["icsUrl1", "targetCalendar1"], | ||
| ["icsUrl2", "targetCalendar2"], | ||
| ["icsUrl2", "targetCalendar2", "11"], |
There was a problem hiding this comment.
I think this is the final request from me - let's remove the "11" in the example array. There's already an example in the comment above and I think that is good enough.
* Supporting event colors * Going for the initial examples * Simplifying code * Removing color from array example
|
This needs to validate colorId at some point - latest in createEvent(). |
I was wondering about that. Figured it was fine, but guess not. @leog can you verify and, if needed, create another PR to do something like |
Forget that part, it actually does accept null. However i still think it would be smart to validate the colorId. |
|
Sorry, I just caught your comments post-merge. The value if no colorId is added is actually |
I needed to differentiate between my original events and my imported events through this marvelous script so I looked up that the
colorIdwas available and unused so I added it. Hopefully this is also a nice-to-have for other people which is why I wanted to contribute it 👍