several fixes for reported issues #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source.url has to be a http(s) link otherwise the event will be rejected by the API.
Will take changed calendar names into account and only select calendars the user actually owns.
The script was unable to update recurrence-exceptions for infinite (or very long) recurrences
Should take care of the rate limit issue mentioned in #175
This will have drawbacks but should allow to sync successfully.
Added All Day Recurrence Exception Support Replaced Calendar.Events.patch with Calendar.Events.insert, patching does not make sense and will cause issues when patching an all day event to a normal event (or vv)
|
@jonas0b1011001 ping on this - if you have a chance, I'd like to pull these in and release a new version. Let me know if you want any clarification on my comments |
|
Done, sorry for the delay. |
derekantrican
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore unsupported 'url' properties
More robust targetCalendar selection
Handle RDates when onlyFutureEvents = true
Improved Recurrence Exception Handling
Add Backoff to cleanup procedure
Add support for Events without uid