Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Recurrence of All-Day Meetings Fails With "Error: invalid date-time value" #127

Closed
k3vmcd opened this issue May 20, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@k3vmcd
Copy link

k3vmcd commented May 20, 2020

  • Description of the problem
    Steps to Reproduce:
  1. Create All-Day recurring event
    image
  2. Modify recurrence of one meeting instance (i.e., "break" recurrence pattern)
    image
  3. Run GAS-ICS-Sync function
  4. Fail with "Error: invalid date-time value" with stacktrace:
Error: invalid date-time value: "<MODIFIED_DATE_VALUE_OF_BROKEN_RECURRENCE_MEETING>"
    at ICAL.Time.fromDateTimeString(ical.js:5837:13)
    at processEvent(Helpers:170:17)
    at [unknown function](Code:175:9)
    at startSync(Code:174:15)



  • An input ics string that can reproduce the problem
BEGIN:VEVENT
CLASS:PUBLIC
CREATED:20200520T165046Z
DTEND;VALUE=DATE:20200522
DTSTAMP:20200520T165219Z
DTSTART;VALUE=DATE:20200521
LAST-MODIFIED:20200520T165200Z
PRIORITY:5
RRULE:FREQ=DAILY;COUNT=45;INTERVAL=2
SEQUENCE:0
SUMMARY;LANGUAGE=en-us:Test Event
TRANSP:TRANSPARENT
UID:64416C02-38FD-4605-A8CD-DB4028A4771A
X-MICROSOFT-CDO-BUSYSTATUS:FREE
X-MICROSOFT-CDO-IMPORTANCE:1
X-MICROSOFT-DISALLOW-COUNTER:FALSE
END:VEVENT
BEGIN:VEVENT
CLASS:PUBLIC
CREATED:20200520T165200Z
DTEND;VALUE=DATE:20200523
DTSTAMP:20200520T165219Z
DTSTART;VALUE=DATE:20200522
LAST-MODIFIED:20200520T165200Z
PRIORITY:5
RECURRENCE-ID;VALUE=DATE:20200523
SEQUENCE:0
TRANSP:TRANSPARENT
UID:64416C02-38FD-4605-A8CD-DB4028A4771A
X-MICROSOFT-CDO-BUSYSTATUS:FREE
X-MICROSOFT-CDO-IMPORTANCE:1
END:VEVENT
@k3vmcd k3vmcd added the bug Something isn't working label May 20, 2020
@jonas0b1011001
Copy link
Collaborator

Hi,

thanks for the report, there should be an easy fix:

  1. Open the script in your Google Drive
  2. Open Helpers.gs
  3. Press ctrl + F, search for "fromDateTimeString" and replace all with "fromString"

@k3vmcd
Copy link
Author

k3vmcd commented May 20, 2020

Confirmed this change works. Thanks!

All other functionality appears to function as normal with this modification. Why not make this the default?

@jonas0b1011001
Copy link
Collaborator

Because I was not aware of the bug until now :)
Will be in the next version!

@k3vmcd
Copy link
Author

k3vmcd commented May 20, 2020

Ah, perfect. I appreciate the help!

jonas0b1011001 added a commit that referenced this issue May 20, 2020
jonas0b1011001 added a commit that referenced this issue Jun 4, 2020
…synced (e.g. #81)

* Fix AllDay Recurrence Exceptions

As in #127

* Fix Outlook rec-id issues

Outlook event sometimes have a rec-id property without being part of a recurrence series. These events will now be added even though the script does not find the original instance it is updating.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants