Merge pull request #274 from mskeving/query-get

Prevent using saved query if new expression doesn't match hash
derbyjs · Feb 29, 2020 · fd5632a · fd5632a
2 parents 62a0774 + a02856c
commit fd5632a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/Model/Query.js b/lib/Model/Query.js
@@ -153,7 +153,7 @@ Queries.prototype.toJSON = function() {
 function Query(model, collectionName, expression, options) {
   this.model = model.pass({$query: this});
   this.collectionName = collectionName;
-  this.expression = expression;
+  this.expression = util.deepCopy(expression);
   this.options = options;
   this.hash = queryHash(collectionName, expression, options);
   this.segments = ['$queries', this.hash];

diff --git a/test/Model/query.js b/test/Model/query.js
@@ -16,6 +16,20 @@ describe('query', function() {
     });
   });
 
+  describe('Query', function() {
+    beforeEach('create in-memory backend and model', function() {
+      this.backend = racer.createBackend();
+      this.model = this.backend.createModel();
+    });
+    it('Uses deep copy of query expression in Query constructor', function() {
+      var expression = {arrayKey: []};
+      var query = this.model.query('myCollection', expression);
+      query.fetch();
+      expression.arrayKey.push('foo');
+      expect(query.expression.arrayKey).to.have.length(0);
+    });
+  });
+
   describe('idMap', function() {
     beforeEach('create in-memory backend and model', function() {
       this.backend = racer.createBackend();